Add Microsoft.CodeAnalysis.AnalyzerUtilities.dll to poison baseline #17005
Conversation
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
I am fine with these changes for Preview 7 but I think we need to discuss what long term solution we want to utilize if we have a poison leak that we don't want to block on for whatever reason, we should have a mechanism in place that allows it. Either we keep the PoisonTests in place even when we get poison clean again or we add a mechanism to the CheckForPoison msbuild task to support allowed leaks when FailOnPoisonFound
|
I'm in favor of keeping the poison tests in place. I don't want to have to reinvent the wheel just to get rid of the tests. |
I am fine with that. One advantage that gives is that if there is a poison leak, we can get a more complete assessment of the quality because all of the tests will run rather than the build failing because of a leak. |
I think that is better approach - a solution that works. It is proving too costly to allow new poisons to break the build and force the team to work on immediate resolution. |
3 participants
Recently, Microsoft.CodeAnalysis.AnalyzerUtilities.dll has showed up as a SB poison leak in the VMR build. For now, we're going to need to allow this for .NET 8 Preview 7 release. Since poison leaks currently break the build as error, we need to disable that and instead use poison tests with a baseline that includes this file. This will allow for passing builds. These changes revert most of the changes that were made in #16631 which got rid of the poison tests.