Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to definition on external dependency/metadata is broken in 17.4 #13906

Closed
vzarytovskii opened this issue Sep 15, 2022 · 1 comment · Fixed by #13956
Closed

Go to definition on external dependency/metadata is broken in 17.4 #13906

vzarytovskii opened this issue Sep 15, 2022 · 1 comment · Fixed by #13956
Assignees
@vzarytovskii
Labels
Area-LangService-Navigation go to definition, F1 help + the FCS APIs related to it Regression
Milestone
September-2022

Comments

@vzarytovskii
Copy link
Member

image

BCL/external dependency metadata navigation. I'm pressing F12 on this to no avail (it used to work). Perhaps it's a different use case.

Yep, doesn't work for me for Newtonsoft.Json.

Originally posted by @vzarytovskii in #13882 (comment)
@vzarytovskii vzarytovskii self-assigned this Sep 15, 2022
@vzarytovskii vzarytovskii added Regression Area-LangService-Navigation go to definition, F1 help + the FCS APIs related to it labels Sep 15, 2022
@vzarytovskii vzarytovskii added this to the September-2022 milestone Sep 15, 2022
@vzarytovskii vzarytovskii changed the title Go to definition on external dependency/on metadata is broken in 17.4 Go to definition on external dependency/metadata is broken in 17.4 Sep 15, 2022
@dotnet dotnet deleted a comment Sep 15, 2022
vzarytovskii added a commit to vzarytovskii/fsharp that referenced this issue Sep 21, 2022
@vzarytovskii
Fix dotnet#13906
15ee3f2
@vzarytovskii vzarytovskii mentioned this issue Sep 21, 2022
Closed
@vzarytovskii
Copy link
Member Author

#13943 will be an intermediate fix, proper fix would be to use MetadataAsSource (#13951)

@vzarytovskii vzarytovskii linked a pull request Sep 26, 2022 that will close this issue
Implement mouseover tooltips for keywords #13956
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzarytovskii vzarytovskii

Labels
Area-LangService-Navigation go to definition, F1 help + the FCS APIs related to it Regression
Projects
F# Compiler and Tooling
Archived in project
Milestone
September-2022
Development

Successfully merging a pull request may close this issue.

Implement mouseover tooltips for keywords dotnet/fsharp
Fix #13906 vzarytovskii/fsharp
1 participant
@vzarytovskii