Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to MetadataAsSource as oppose of creating new project context #13951

Open
vzarytovskii opened this issue Sep 21, 2022 · 2 comments
Open

Move to MetadataAsSource as oppose of creating new project context #13951

vzarytovskii opened this issue Sep 21, 2022 · 2 comments
Assignees
@vzarytovskii
Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Feature Improvement
Milestone
Backlog

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Sep 21, 2022 •
edited
Loading

Chatted with @tmat about an issue we are having navigating to metadata, we need to move to using MetadataAsSource instead of creating an on-demand project context, as we do now.

Project contexts have different purpose. We should move off of it.

Additionally, we need to support Source Link go to definition in VS. @davidwengier may know more about the topic.
@vzarytovskii vzarytovskii added Area-VS-Editor VS editor support for F# code, not covered elsewhere Area-LangService-Navigation go to definition, F1 help + the FCS APIs related to it Area-VS VS support for F# not covered elsewhere labels Sep 21, 2022
@vzarytovskii vzarytovskii added this to the September-2022 milestone Sep 21, 2022
@vzarytovskii vzarytovskii self-assigned this Sep 21, 2022
@vzarytovskii vzarytovskii mentioned this issue Sep 21, 2022
Closed
@tmat
Copy link
Member

tmat commented Sep 21, 2022

I think it would be best to define an internal interface between Roslyn and F# that allows F# to plug into our MAAS and Source Link GTD UI and implementation. Essentially just abstract what's specific to C#/VB in a way that F# can provide their implementation.

@vzarytovskii vzarytovskii modified the milestones: September-2022, Backlog Sep 26, 2022
@vzarytovskii vzarytovskii mentioned this issue Oct 3, 2022
Open
@0101 0101 added Feature Improvement and removed Area-LangService-Navigation go to definition, F1 help + the FCS APIs related to it Area-VS VS support for F# not covered elsewhere Needs-Triage labels Mar 13, 2023
@vzarytovskii vzarytovskii mentioned this issue Nov 13, 2023
Closed
@cataggar
Copy link

I opened Develop Community Visual F# Go to definition from Source Link in order to get a work item that I can link to as a planning dependency.

@vsfeedback vsfeedback mentioned this issue Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzarytovskii vzarytovskii

Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Feature Improvement
Projects
F# Compiler and Tooling
Status: New
Milestone
Backlog
Development

No branches or pull requests
4 participants
@tmat @0101 @vzarytovskii @cataggar