-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mouseover tooltips for keywords #13956
Conversation
* Streamlining dependencies around Microsoft.CodeAnalysis * Update
…ment-tooltips-for-keywords
…ment-tooltips-for-keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'd probably remove the icons at all, I don't see any particular value in having them whereas they take space :)
Otherwise - awesome!
We do use icons in other tooltips, always fitting the respective token (property, class, method,... have their own icons). |
- updating .expected SurfaceArea file
Sure. I don't have a strong opinion here :) |
@@ -31,6 +31,8 @@ type public ToolTipElementData = | |||
ParamName: string option | |||
} | |||
|
|||
static member Create: layout: TaggedText[] * xml: FSharpXmlDoc * ?typeMapping: TaggedText[] list * ?paramName: string * ?remarks: TaggedText[] -> ToolTipElementData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be internal please? I think it is only used from FSharpCheckerResults.fs? Thanks
@@ -344,6 +344,9 @@ module FSharpKeywords = | |||
/// Keywords paired with their descriptions. Used in completion and quick info. | |||
val KeywordsWithDescription: (string * string) list | |||
|
|||
/// A lookup from keywords to their descriptions | |||
val KeywordsDescriptionLookup: System.Collections.Generic.IDictionary<string, string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a string -> string option
method please, GetKeywordDescription
? Rather than revealing an IDictionary?
This PR implements mouseover tooltips for keywords in Visual Studio.
This already works in FsAutoComplete (Ionide) and this new VS implementation uses the same data source, provided by Compiler Services.
Here is a visual example.
REMARK:
In order to test, I had to rebase this branch on top of recent "packages-update" of all Roslyn and Visual Studio packages.
Without it, "build.cmd -testVS" was failing in latest Int Preview version of visual studio.