This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
dropped to released version of piplelines #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyKuhne
approved these changes
Oct 26, 2018
|
@dotnet-bot test Innerloop OSX10.12 Release Build and Test |
|
The latest pipelines package from master also has its own dependency issue due to System.Buffers which is blocking #2550 which was fixed by dotnet/corefx#32992. So dropping to release is fine. However, I don't understand why it is necessary for you. Also, remove it from the update-Dependencies project or it will change again when a new build comes out (with auto-PR): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview version of pipelines is not in corfxlab myget not on nuget.org. This means adding System.Buffers.ReaderWriter to a project fails, unless the project has pipelines myget feed (which is not common or intuitive). Since ReaderWriter (nor any components in corfxlab) needs preview of pipelines, I am dropping the pipelines dependency to the officially released on nuget.org.