This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Pin System.Buffers ref assembly to what we shipped inbox #32992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd really prefer if we can have an answer for this. Having issues tracking test-only work seem to never get done. It will also help increase confidence that we don't have more issues like this. |
I agree. I will fix it, but I want to unblock @ahsonkhan that is why I provided the minimal PR now, but in the meantime I will be investigating the test issue. |
I broke this in fd88574 Ensure we use a different property for inner/outer test.
ericstj
force-pushed
the
PinSystemBuffers
branch
from
6f2a47b to
0eb5019
Compare
|
test Linux x64 Release Build |
1 similar comment
|
test Linux x64 Release Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…fx#32992) * Pin System.Buffers ref assembly to what we shipped inbox * Fixing package testing I broke this in dotnet/corefx@fd88574 Ensure we use a different property for inner/outer test. Commit migrated from dotnet/corefx@407c09d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #32984
I will not close the issue as still need to investigate why we didn't catch this when validating upstack in our package testing.
cc: @ericstj