This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Revert dependencies down to release versions of the packages #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
commented
Oct 29, 2018
| <ProjectReference Include="..\System.Text.Utf8String\System.Text.Utf8String.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesVersion)" /> |
There was a problem hiding this comment.
ReaderWriter shouldn't depend on the higher level library (it should be the other way around).
By moving IPipeWritable.cs to Experimental, we can remove this dependency.
ahsonkhan
commented
Oct 29, 2018
| @@ -2,16 +2,16 @@ | |||
| <Import Project="..\..\tools\common.props" /> | |||
| <PropertyGroup> | |||
| <Description>Buffer Readers, Writers, and Transformations</Description> | |||
| <TargetFramework>netstandard1.3</TargetFramework> | |||
There was a problem hiding this comment.
Currently, we can support netstandard1.1.
|
@dotnet-bot test Innerloop OSX10.12 Release Build and Test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding on top of the changes from #2571.
cc @KrzysztofCwalina, @JeremyKuhne