Try out new .NET 6 logging generator

[JamesNK]

.NET 6 has a feature to generate logging classes from attributes. Could reduce the amount of boilerplate in our logging types while also validating log event IDs aren't duplicated.

See dotnet/runtime#36022

We should try replacing some small static Log types with the new feature.

• HttpAbstractions
• Kestrel
• Middleware
• HttpSys
• Mvc
• Components
• SignalR

[davidfowl]

I asked @maryamariyan to give it a try. I think there are some issues that will prevent full adoption but we should I aim to move.

cc @gfoidl

[gfoidl]

If @maryamariyan's try succeedes I'd like to broaden that usage here (this generator seems really cool).
Further it's a good opportunity to detect some potential flaws and improve that generator before shipping .NET 6.

[ghost]

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[gfoidl]

I made a quick test with the logging generator and it looks very promising, so I believe we can use that for some logging that needs to written new or to be rewritten (like the Kestrel trace).

[alefranz]

Looking forward for this. Let me know if you are looking for help.

[gfoidl]

ATM there are two (?) points that should get addressed before we can use the logging generator:

• allow nested classes Support nested logging classes in Logging Source Generator runtime#52301
• allow skipEnabledCheck Logging-Generator should allow to skip the IsEnabled check runtime#51927

[alefranz]

Thanks for the quick reply! Is it worth removing the help wanted label here and add it to the linked issues if/when appropriate?

[maryamariyan]

Opened this issue dotnet/runtime#52549 to list up logging generator related issues. Not all need to be addressed right away.

@gfoidl I think dotnet/runtime#51927 depends on how we end up with the API review on dotnet/runtime#50913

[gfoidl]

IMO dotnet/runtime#51927 is quite independent from dotnet/runtime#50913. The logging generator can skip the IsEnabled-check if there's a LoggerMessage.Define overload, otherwise (in the fallback case) ignore that "hint" which is merely an optimization.

I know that dotnet/runtime#51927 needs to be reviewed too, but when touching the logging for Kestrel, etc. it would be nice that it can be done once and use the goodness from the new logging generator.
It looks very promising, just some tiny pieces are missing (linked issues / also your list).

[adityamandaleeka]

Thanks @pranavkm for making a bunch of progress here. Moving to .NET 7 milestone to cover the remainder.