Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LoggerMessageAttribute in more places #40297

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Use LoggerMessageAttribute in more places #40297

merged 4 commits into from
Feb 23, 2022

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 18, 2022 •
edited
Loading

  • Servers
  • Antiforgery
  • Missed Blazor and Security projects

Contributes to #32087

@pranavkm
Use LoggerMessageAttribute in more places
e01773a 
* Servers
* Antiforgery
* Missed Blazor and Security projects
@davidfowl
Copy link
Member

Very nice!

Tratcher
Tratcher approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the IIS visibility error?

@pranavkm
Copy link
Contributor Author

What's with the IIS visibility error?

Messed up the merge conflict with @halter73's PR: 0bd4a69

@pranavkm pranavkm enabled auto-merge (squash) February 22, 2022 23:45
@pranavkm pranavkm merged commit d3a98b2 into dotnet:main Feb 23, 2022
@pranavkm pranavkm deleted the logger-message-1 branch February 23, 2022 01:47
@ghost ghost added this to the 7.0-preview3 milestone Feb 23, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@pranavkm @davidfowl @Tratcher @amcasey @mkArtakMSFT