Update Mvc to use LoggerMessageAttribute

[david-acker]

Updates the Mvc project to use the LoggerMessageAttribute for logging generation.

Description

The following files contained duplicate log event ids which had to be renumbered:

• MvcCoreLoggerExtensions
• MvcRazorLoggerExtensions
• MvcViewFeaturesLoggerExtensions
• RazorRuntimeCompilationLoggerExtensions

Also fixes a typo in a method name in RazorRuntimeCompilationLoggerExtensions:
ViewCompilerInvalidingCompiledFile --> ViewCompilerInvalidatingCompiledFile

Completes the Mvc task for #32087

[pranavkm]

@david-acker are you manually updating these logger messages? I used a code-fix to do this in the past because it's far too easy to introduce errors / typos with such a large number of messages and it's incredibly difficult to review these in a PR. https://github.com/pranavkm/LoggerConvert has a version of the codefix, perhaps you want to give that a go (in a separate branch so you don't lose these changes)?

[david-acker]

@pranavkm Ah, a code fix definitely seems like the best way to handle this. I just wrote a script to generate the logger message attribute and partial methods from the original LoggerMessage.Define implementations, although I did manually go through and remove the original extension methods which were replaced by the new logger messages.

I'll go back and use the code fix you created just to ensure that no errors or typos will slip through.

[mkArtakMSFT]

Thanks for your PR.
@pranavkm can you please review this? Thanks!

[pranavkm]

@david-acker these changes look good. If you'd like to make this PR non-draft, I'd be happy to get it merged.

[david-acker]

Sounds good! There's still a decent amount of the original LoggerMessages in MvcCoreLoggerExtensions that still need to be converted, but it might be best to leave that for another PR to keep to scope down.

[pranavkm]

Thanks! We can always tackle the remaining messages iteratively.

[HaoK]

@pranavkm this looks like it broke the build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1562862&view=logs&j=1b89928a-2219-5ef9-602f-f95beb3da4dc&t=31281680-1367-5e42-8b2d-0ecd34ac2092 Can you fix (or revert if its not straightforward)?

[pranavkm]

On it.

[david-acker]

@pranavkm Just put up a PR to fix this. Odd that the previous CI runs didn't catch this.

[ghost]

Hi @david-acker. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.