Skip to content

Conversation

@Alirexaa
Copy link
Contributor

Description

This pull request enhances the Qdrant integration by adding URL annotations for endpoints and introducing a new functional test to verify the changes. The most important updates are as follows:

Enhancements to Qdrant Integration:

  • src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs: Added .WithUrlForEndpoint calls to annotate the PrimaryEndpointName and HttpEndpointName with display text ("Qdrant (GRPC)" and "Qdrant (HTTP)", respectively). This provides more descriptive endpoint information.

New Functional Test:

Fixes #8809

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 17, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 17, 2025
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good

@davidfowl davidfowl merged commit b72eb4f into dotnet:main Apr 18, 2025
175 checks passed
@davidfowl
Copy link
Member

Thanks @Alirexaa !

@Alirexaa Alirexaa deleted the qdrant-endpoints-display-name branch April 18, 2025 07:35
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add display name to make it easier to distinguish quadrant's HTTP and gRPC endpoints

2 participants