Skip to content

Add display name for Qdrant's HTTP and GRPC endpoints #8840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

Add display name for Qdrant's HTTP and GRPC endpoints #8840

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8aa1c9
Add display name for Qdrant's HTTP and GRPC endpoints
Alirexaa Apr 17, 2025
030fd22
fix typo
Alirexaa Apr 17, 2025
f18ad37
Display GRPC port only in details and add qdant dashbord url to urls
Alirexaa Apr 17, 2025
9c12468
Address PR feedback
Alirexaa Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ public static IResourceBuilder<QdrantServerResource> AddQdrant(this IDistributed
context.EnvironmentVariables[EnableStaticContentEnvVarName] = "0";
}
})
.WithHealthCheck(healthCheckKey);
.WithHealthCheck(healthCheckKey)
.WithUrlForEndpoint(QdrantServerResource.PrimaryEndpointName, c => c.DisplayText = "Qdrant (GRPC)")
.WithUrlForEndpoint(QdrantServerResource.HttpEndpointName, c => c.DisplayText = "Qdrant (HTTP)");
}

/// <summary>
Expand Down Expand Up @@ -179,7 +181,7 @@ private static QdrantClient CreateQdrantClient(string? connectionString)
{
throw new InvalidOperationException("Endpoint is unavailable");
}

var client = new QdrantClient(endpoint, key);
return client;
}
Expand Down
26 changes: 26 additions & 0 deletions tests/Aspire.Hosting.Qdrant.Tests/QdrantFunctionalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,32 @@ await pipeline.ExecuteAsync(async token =>
}
}

[Fact]
[RequiresDocker]
public async Task AddQdrantWithDefaultsAddsUrlAnnotations()
{
using var builder = TestDistributedApplicationBuilder.Create();

var qdrant = builder.AddQdrant("qdrant");

var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
builder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
{
tcs.SetResult();
return Task.CompletedTask;
});

var app = await builder.BuildAsync();
await app.StartAsync();
await tcs.Task;

var urls = qdrant.Resource.Annotations.OfType<ResourceUrlAnnotation>();
Assert.Single(urls, u => u.Endpoint!.EndpointName == "grpc" && u.DisplayText == "Qdrant (GRPC)");
Assert.Single(urls, u => u.Endpoint!.EndpointName == "http" && u.DisplayText == "Qdrant (HTTP)");

await app.StopAsync();
}

[Fact]
[RequiresDocker]
public async Task VerifyWaitForOnQdrantBlocksDependentResources()
Expand Down
Loading