-
Notifications
You must be signed in to change notification settings - Fork 376
Should not publish the files in SymbolPublishingExclusionFile.txt #7433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc : @garath another test against this dotnet/installer#10685 changes will be good. |
|
Probably I will add a FAQ, on how to use this feature in product repos |
|
issue -> #7705 |
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
|
This looks like it broke the runtime official build https://dev.azure.com/dnceng/internal/_build/results?buildId=1283309&view=results |
|
The reason this fixed failed is cos arcade needed an arcade update. So only the post build thing happened and the first part where we upload the file to the container did not happen. So I am going to recreate this PR and I am running another test in runtime to prove this. |
|
Ran a runtime publishing build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284774&view=results Also this is the runtime build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284469&view=results Here is the place where the symbolsExclusion file is uploaded This was missing the previous build, so publishing failed. |

To double check:
sdk Test -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1272580&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a