Skip to content

Conversation

@epananth
Copy link
Member

@epananth epananth commented May 22, 2021

@epananth
Copy link
Member Author

cc : @garath another test against this dotnet/installer#10685 changes will be good.

@epananth epananth changed the title Should not publish the files in SymbolPublishingExclusionFile.txt (WIP - no review needed yet) Should not publish the files in SymbolPublishingExclusionFile.txt May 22, 2021
@epananth epananth changed the title (WIP - no review needed yet) Should not publish the files in SymbolPublishingExclusionFile.txt Should not publish the files in SymbolPublishingExclusionFile.txt Aug 4, 2021
@epananth
Copy link
Member Author

epananth commented Aug 4, 2021

Probably I will add a FAQ, on how to use this feature in product repos

@epananth
Copy link
Member Author

epananth commented Aug 4, 2021

issue -> #7705

@riarenas riarenas requested review from mmitche and riarenas August 4, 2021 16:13
@epananth epananth merged commit 7e675d4 into dotnet:main Aug 5, 2021
@lewing
Copy link
Member

lewing commented Aug 9, 2021

This looks like it broke the runtime official build https://dev.azure.com/dnceng/internal/_build/results?buildId=1283309&view=results

@epananth
Copy link
Member Author

epananth commented Aug 9, 2021

The reason this fixed failed is cos arcade needed an arcade update. So only the post build thing happened and the first part where we upload the file to the container did not happen. So I am going to recreate this PR and I am running another test in runtime to prove this.

@epananth
Copy link
Member Author

Ran a runtime publishing build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284774&view=results

Also this is the runtime build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284469&view=results

Here is the place where the symbolsExclusion file is uploaded

image

This was missing the previous build, so publishing failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants