Skip to content

Should not publish the files in SymbolPublishingExclusionFile.txt #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epananth merged 40 commits into from
Aug 5, 2021
Merged

Should not publish the files in SymbolPublishingExclusionFile.txt #7433

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
dc4001f
symbols test
epananth May 20, 2021
3962338
test-sdk
epananth May 20, 2021
d972aa0
test path
epananth May 20, 2021
34b1862
Test
epananth May 22, 2021
7d529ec
test sdk
epananth May 22, 2021
685a8fb
revert test changes
epananth May 22, 2021
dc69764
Merge branch 'main' of https://github.com/dotnet/arcade into excludeS…
epananth May 22, 2021
57bc896
test
epananth Jun 2, 2021
70610b0
test
epananth Jun 2, 2021
a802f7a
Test
epananth Jun 3, 2021
68b8694
merge conflict
epananth Jun 8, 2021
0ac2301
Test symbols download
epananth Jun 9, 2021
9cf085c
fix
epananth Jun 9, 2021
13fbcfd
fix
epananth Jun 9, 2021
a008035
Test
epananth Jun 9, 2021
f645083
Test
epananth Jun 9, 2021
8a660b9
Test
epananth Jun 11, 2021
852c836
test
epananth Jun 24, 2021
599344d
Merge branch 'main' of https://github.com/dotnet/arcade into excludeS…
epananth Jul 29, 2021
5759cb1
test
epananth Jul 29, 2021
055cbc3
test
epananth Jul 29, 2021
ed7539b
test
epananth Jul 30, 2021
3802501
TEst
epananth Jul 30, 2021
4967e16
test
epananth Jul 30, 2021
40e4c5b
Merge branch 'main' of https://github.com/dotnet/arcade into excludeS…
epananth Jul 30, 2021
6a369ef
updated
epananth Jul 31, 2021
f6f6ec6
test
epananth Aug 2, 2021
faba61e
Test
epananth Aug 3, 2021
63c1c9e
Test
epananth Aug 3, 2021
b58987e
typo
epananth Aug 3, 2021
7fdedd8
test
epananth Aug 3, 2021
3a043b4
Test
epananth Aug 3, 2021
6fd3a3f
test variable
epananth Aug 3, 2021
f40d540
check if file exists
epananth Aug 3, 2021
1354def
minor fixes
epananth Aug 4, 2021
c5a73f7
Revert test changes
epananth Aug 4, 2021
7e4e1d7
Review comments
epananth Aug 4, 2021
11c6e18
default value
epananth Aug 4, 2021
1c81853
fix
epananth Aug 4, 2021
055c610
use this in the right place
epananth Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<MicrosoftExtensionsLoggingConsoleVersion>2.1.1</MicrosoftExtensionsLoggingConsoleVersion>
<MicrosoftNETCorePlatformsVersion>2.1.0</MicrosoftNETCorePlatformsVersion>
<MicrosoftNetCompilersToolsetVersion>3.10.0-4.21262.12</MicrosoftNetCompilersToolsetVersion>
<MicrosoftNETILLinkTasksVersion>6.0.100-preview.5.21268.2</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkTasksVersion>6.0.100-preview.5.21270.1</MicrosoftNETILLinkTasksVersion>
<MicrosoftNetTestSdkVersion>16.7.1</MicrosoftNetTestSdkVersion>
<MoqVersion>4.8.3</MoqVersion>
<MonoOptionsVersion>5.3.0.1</MonoOptionsVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/publishing/v3/publish-assets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
/p:AkaMSClientSecret=$(akams-client-secret)
${{ parameters.artifactsPublishingAdditionalParameters }}
/p:PDBArtifactsBasePath='$(Build.ArtifactStagingDirectory)/PDBArtifacts/'
/p:SymbolPublishingExclusionsFile='$(Build.SourcesDirectory)/eng/SymbolPublishingExclusionsFile.txt'
/p:SymbolPublishingExclusionsFile='/eng/SymbolPublishingExclusionsFile.txt'
Comment thread
epananth marked this conversation as resolved.
Outdated
${{ parameters.symbolPublishingAdditionalParameters}}
/p:MsdlToken=$(microsoft-symbol-server-pat)
/p:SymWebToken=$(symweb-symbol-server-pat)
Expand Down
16 changes: 14 additions & 2 deletions src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,18 @@ public async Task PublishSymbolsUsingStreamingAsync(
HashSet<TargetFeedConfig> feedConfigsForSymbols = FeedConfigs[symbolCategory];
Dictionary<string, string> serversToPublish =
GetTargetSymbolServers(feedConfigsForSymbols, msdlToken, symWebToken);
HashSet<string> excludeFiles = new HashSet<string>();

if(File.Exists(symbolPublishingExclusionsFile)){
Log.LogMessage(MessageImportance.High, $"SymbolPublishingExclusionFile exists");
Comment thread
epananth marked this conversation as resolved.
Outdated
string[] files = File.ReadAllLines(symbolPublishingExclusionsFile);

foreach(var file in files){
Log.LogMessage(MessageImportance.High, $"Exclude the file {file} from publishing to symbol server");
excludeFiles.Add(file);
}

}

if (symbolsToPublish != null && symbolsToPublish.Any())
{
Expand Down Expand Up @@ -465,7 +477,7 @@ await PublishSymbolsHelper.PublishAsync(
token,
symbolFiles,
null,
null,
excludeFiles,
ExpirationInDays,
false,
publishSpecialClrFiles,
Expand Down Expand Up @@ -531,7 +543,7 @@ await PublishSymbolsHelper.PublishAsync(
token,
null,
filesToSymbolServer,
null,
excludeFiles,
ExpirationInDays,
false,
publishSpecialClrFiles,
Expand Down