Create WASM installers for optional workloads #10685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
commented
May 19, 2021
| <ItemGroup> | ||
| <!-- Overrides for Visual Studio setup generation. If the workload definition IDs change, | ||
| these must be updated. --> | ||
| <ComponentResources Include="microsoft-net-sdk-blazorwebassembly-aot" Title=".NET WebAssembly Build Tools" |
Member
Author
There was a problem hiding this comment.
@danroth27 @lewing can you take a look at the title/description. This is what would show in VS setup UI
danroth27
approved these changes
May 19, 2021
Member
Author
|
We're likely going to be blocked on merging until dotnet/arcade#7420 is resolved and we take new Arcade update in Installer. |
1 task
wli3
approved these changes
May 24, 2021
| @@ -1,17 +1,25 @@ | |||
| { | |||
| "sdk": { | |||
Member
Author
There was a problem hiding this comment.
That allows Arcade to install the local SDK so that full framework msbuild can locate it. This was the recommendation from Arcade to help address the issue where a local SDK can't be located (together with the change in configure-toolset.ps1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new build leg to create WASM installers for .NET optional workloads