Add missing ValueTask support with InProcessNoEmit toolchain #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
from
2e61a39
to
369133b
Compare
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
from
369133b
to
b713a94
Compare
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
3 times, most recently
from
eb777c7
to
4d6159c
Compare
timcassell
changed the title
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
from
ce3b1c7
to
fe412ff
Compare
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
2 times, most recently
from
ba5dfb2
to
4d2a07a
Compare
…tion between `IsCompleted` and `OnCompleted`. Changed AwaitHelper to use `ManualResetEventSlim` instead of `Monitor.Wait`.
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
from
4d2a07a
to
c51c486
Compare
timcassell
force-pushed
the
valuetask-nongeneric-inprocess
branch
from
26bab1d
to
c51c486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2108, split from #1941 (the changes here will be much smaller if #2108 is merged first).