Fix ValueTask #1941
Closed
Fix ValueTask #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
force-pushed
the
fix-valuetask
branch
from
f5f48b9
to
e004ec6
Compare
timcassell
force-pushed
the
fix-valuetask
branch
from
bb11b0b
to
f52e351
Compare
Closed
Updated BenchmarkType and InProcess toolchains to use AwaitHelper.
…lchain. Added support for `ValueTask` benchmark in InProcess.NoEmit. Added tests.
…nt in-process deadlocks.
timcassell
force-pushed
the
fix-valuetask
branch
from
f790a14
to
39bdbea
Compare
This was referenced Sep 20, 2022
|
Split out to 3 separate PRs for easier review (and I added more tests) #2108, #2109, and #2110. cc @YegorStepanov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595 and fixes #1738
I also added
ValueTask(non-generic) support for InProcess toolchains that was missing.