-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consume ValueTask backed by IValueTaskSource #2108
Conversation
fa2790e
to
5720494
Compare
15864fe
to
f9c6342
Compare
f9c6342
to
f0acf70
Compare
f0acf70
to
68e4459
Compare
@adamsitnik Can you take a look? |
@AndreyAkinshin |
I have no objection to removing |
0dc5813
to
43138da
Compare
@ig-sinicyn I touched the InProcess toolchains here, can you take a look? |
@timcassell, great job! There should be a diff test that proves that emitted IL matches with compiled c# code. If it passes, all should be fine. |
43138da
to
13f5a0b
Compare
…tion between `IsCompleted` and `OnCompleted`. Changed AwaitHelper to use `ManualResetEventSlim` instead of `Monitor.Wait`.
c63babc
to
584fe39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns from my side. If @adamsitnik has no objections, we can merge it.
Fixes #1595.
This was originally #1941, but I split it out to just include the
ValueTask
fixes (and I added more tests).