Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consume ValueTask backed by IValueTaskSource #2108

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Fix consume ValueTask backed by IValueTaskSource #2108

merged 6 commits into from
Mar 19, 2024

Conversation

timcassell
Copy link
Collaborator

Fixes #1595.

This was originally #1941, but I split it out to just include the ValueTask fixes (and I added more tests).

This was referenced Sep 20, 2022
Open
Closed
Open
Closed
@timcassell timcassell changed the title Fix consume ValueTask Fix consume ValueTask backed by IValueTaskSource Sep 20, 2022
@timcassell timcassell mentioned this pull request Sep 26, 2022
Open
@timcassell
Copy link
Collaborator Author

@adamsitnik Can you take a look?

@timcassell
Copy link
Collaborator Author

@AndreyAkinshin InProcessToolchain has been deprecated in favor of InProcessNoEmitToolchain since #1123 (almost 4 years ago). I updated it to match the changes I made here and in my other followup PRs, but I wonder if it can just be removed? Or should I just not add the updates and leave it in its old state? It's not good to maintain both.

@AndreyAkinshin
Copy link
Member

I have no objection to removing InProcessToolchain. @adamsitnik what do you think?

@timcassell timcassell mentioned this pull request Jan 18, 2023
Merged
@timcassell timcassell force-pushed the fix-valuetask-only branch 2 times, most recently from 0dc5813 to 43138da Compare February 17, 2023 22:15
@timcassell
Copy link
Collaborator Author

@ig-sinicyn I touched the InProcess toolchains here, can you take a look?

@ig-sinicyn
Copy link
Contributor

@timcassell, great job!

There should be a diff test that proves that emitted IL matches with compiled c# code. If it passes, all should be fine.

@timcassell timcassell mentioned this pull request Jun 16, 2023
Closed
AndreyAkinshin
AndreyAkinshin approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from my side. If @adamsitnik has no objections, we can merge it.

@timcassell timcassell merged commit 7306ee7 into dotnet:master Mar 19, 2024
8 checks passed
@timcassell timcassell deleted the fix-valuetask-only branch March 19, 2024 22:08
@timcassell timcassell added this to the v0.14.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

@ig-sinicyn ig-sinicyn ig-sinicyn approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees
No one assigned
Labels
Area:CodeGen
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

ValueTask-returning benchmarks are not being called correctly
3 participants
@timcassell @AndreyAkinshin @ig-sinicyn