-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PHP 8.5 support #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.5 support #986
Conversation
|
Doh, sorry for missing this! 😞 Historically we haven't supported PHP pre-releases in this repository, but I think it could be interesting to explore what that might look like (assuming WordPress upstream supports the given pre-release version, which you might know a thing or two about 😅 ❤️). In this case, that specific point is kind of moot now that 8.5 is GA, but Imagick is still not released yet 😬 Installing (or even just patching) directly from GitHub is something we've done before, but we strongly consider that a solution-of-last-resort (see 509adb5 / #886 for an example of where we've done that in the past with an implementation that hopefully generates the appropriately visceral reaction 😂). |
|
No worries. I kept it as a draft because of the Imagick issues, but otherwise I think RC support would be nice. While WordPress core uses its own Docker images and can test support earlier, the ecosystem otherwise heavily relies on the ones provided here. So anything that helps them test compatibility earlier would be nice. Supporting 8.5 should be relatively simple though for most, so it wasn't urgent. |
|
Imsgick 3.8.1 is out, will update the PR tomorrow. |
|
@tianon all green now :) |
tianon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! 🥳
Changes: - docker-library/wordpress@ee43abe: Update beta - docker-library/wordpress@3ca512a: Add PHP 8.5 support (docker-library/wordpress#986) - docker-library/wordpress@63ce84b: Update beta to 6.9-RC4
Changes: - docker-library/wordpress@b962e97: Use PHP_INI_DIR provided by the php base images (docker-library/wordpress#991) - docker-library/wordpress@ee43abe: Update beta - docker-library/wordpress@3ca512a: Add PHP 8.5 support (docker-library/wordpress#986) - docker-library/wordpress@63ce84b: Update beta to 6.9-RC4
Changes: - docker-library/wordpress@b962e97: Use PHP_INI_DIR provided by the php base images (docker-library/wordpress#991) - docker-library/wordpress@ee43abe: Update beta - docker-library/wordpress@3ca512a: Add PHP 8.5 support (docker-library/wordpress#986) - docker-library/wordpress@63ce84b: Update beta to 6.9-RC4 Co-authored-by: Docker Library Bot <[email protected]>
Blocked by Imagick requiring a new release. The necessary changes there were already made, see Imagick/imagick#741. So maybe the extension could be installed from GitHub instead in the meantime.
Previously: