-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.4 support #932
base: master
Are you sure you want to change the base?
Add PHP 8.4 support #932
Conversation
Would be super cool if we already have a PHP 8.4 image with WordPress to test the compatibility of plugins & themes. Maybe @LaurentGoderre or @tianon can take a look at the PR? |
This is a great idea! Unfortunately, it looks like we get hung up on Imagick/imagick#689 (and thus need Imagick/imagick#690). 😞 |
Has there been any work in WordPress upstream to evaluate this dependency (and alternatives)? |
@tianon I’m not aware of any alternatives being actively considered. Imagemagick is the best option for processing images with PHP. GD is a works too but produces lower-quality images. Main issue is the lack of proper maintainer support of the pecl wrapper library. I think for now, the best approach is patching the library, which is also what Ondřej (maintainer of the widely-used PHP packages for Debian and Ubuntu) does. |
Any updates based on this #932 (comment)? Would be great to have PHP 8.4 :) |
WordPress 6.7 adds PHP 8.4 beta support. The latest commit from imagick is Mar 18, 2023. I think the patch here from @sebcode is the best solution. |
Previously: