Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install target. #495

Merged
merged 7 commits into from
Feb 5, 2019
Merged

Add install target. #495

merged 7 commits into from
Feb 5, 2019

Conversation

trivialfis
Copy link
Member

Export dmlc target in CMake

@trivialfis
Copy link
Member Author

@hcho3

@trivialfis
Add install target.
fb33e45 
* Export `dmlc` in CMake.
* Use GNUInstallDir instead.
@trivialfis
Copy link
Member Author

Just found out this has some duplication to #257 . But this one adds export target.

@trivialfis trivialfis changed the title Add install target. [WIP] Add install target. Jan 6, 2019
@trivialfis
Copy link
Member Author

Make it WIP for now. Will make further commits when CMake update for XGBoost is ready.

@trivialfis trivialfis changed the title [WIP] Add install target. Add install target. Jan 9, 2019
@trivialfis
Copy link
Member Author

@hcho3 I removed filesys.h and moved everything in it into io.h for the following reasons:

  • Originally src/io/filesys.h is included by include/dmlc/filesystem.h, which effectively making it part of interface. But we can't install such a file in CMakeLists.txt since it's located in src/io directory.
  • Simply moving this file into include/dmlc is confusing, what's the reason for having both filesystem.h and filesys.h?
  • Moving it into io.h instead of filesystem.h is because originally filesys.h is located in the sub-directory of src named io.

I added a simple documentation of using dmlc-core with CMake, could you help reviewing this?

@trivialfis trivialfis mentioned this pull request Jan 30, 2019
Merged
@hcho3 hcho3 mentioned this pull request Feb 5, 2019
Closed
@hcho3 hcho3 self-requested a review February 5, 2019 03:08
hcho3
hcho3 approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should help me improve neo-ai-dlr.

@hcho3 hcho3 merged commit 692216e into dmlc:master Feb 5, 2019
hcho3 added a commit to hcho3/dmlc-core that referenced this pull request Feb 5, 2019
@hcho3
Follow-up for dmlc#495: fix config path
4c784c4
hcho3 added a commit that referenced this pull request Feb 5, 2019
@hcho3
Follow-up for #495: fix config path (#501)
9624d26
@eric-haibin-lin eric-haibin-lin mentioned this pull request Mar 25, 2019
Merged
5 tasks
This was referenced Apr 30, 2019
Closed
Closed
@trivialfis trivialfis deleted the install-target branch October 28, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3