Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up for #495: fix config path #501

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Feb 5, 2019

When dmlc-core is used as a git submodule of another project, we should not use CMAKE_SOURCE_DIR.

@hcho3
Copy link
Contributor Author

hcho3 commented Feb 5, 2019

@trivialfis

@hcho3 hcho3 merged commit 9624d26 into dmlc:master Feb 5, 2019
@hcho3 hcho3 deleted the fix_cmake_config_path branch February 5, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant