[TEST] upgrade dmlc-core

[eric-haibin-lin]

Description

Upgrade the dmlc-core dependency to the latest commit.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

• The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage:
• Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
• Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
• Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
• Code is well-documented:
• For user-facing API changes, API doc string has been updated.
• For new C++ functions in header files, their functionalities and arguments are documented.
• For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
• Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
• To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

• relevant fixes for MXNet: Fix #505: remove data race in threaded CSV parser dmlc/dmlc-core#511 dmlc/dmlc-core@8afbca6 thanks to @hcho3
• required by MXNet AMP (automatic mixed precision) #14173

[wkcn]

LGTM: )
Thank you for the update!

[eric-haibin-lin]

Looks like the CMakeFile in dmlc-core has been changed in multiple PRs that causes amalgamation to break:

• FreeBSD support in endian.h dmlc/dmlc-core#476" error: sys/endian.h: No such file or directory"
• Add install target. dmlc/dmlc-core#495 "error: 'backtrace_symbols' was not declared in this scope"
• Enable specifying stacktrace size at runtime. dmlc/dmlc-core#470 "error: "Shlwapi.h: No such file or directory"

[pinaraws]

@mxnet-label-bot add[pr-awaiting-merge]

[hcho3]

@eric-haibin-lin Platform-specific headers such as Shlwapi.h should have been wrapped with platform-specific macros (_WIN32 etc). Does amalgamation not honor platform-specific macros?

[hcho3]

@eric-haibin-lin This patch should fix amalgamation:

diff --git a/amalgamation/amalgamation.py b/amalgamation/amalgamation.py
index 0a4be02b8..edf01941d 100644
--- a/amalgamation/amalgamation.py
+++ b/amalgamation/amalgamation.py
@@ -46,7 +46,13 @@ if platform.system() != 'Darwin':
 if platform.system() != 'Windows':
     blacklist.append('windows.h')
     blacklist.append('process.h')
+    blacklist.append('Shlwapi.h')

+if platform.system() == 'Windows':
+    blacklist.append('unistd.h')
+
+if 'freebsd' not in sys.platform:
+    blacklist.append('sys/endian.h')

 def get_sources(def_file):
     sources = []
@@ -94,6 +100,7 @@ def find_source(name, start, stage):

 re1 = re.compile('<([./a-zA-Z0-9_-]*)>')
 re2 = re.compile('"([./a-zA-Z0-9_-]*)"')
+re3 = re.compile('DMLC_EXECINFO_H')

 sysheaders = []
 history = set([])
@@ -129,6 +136,9 @@ def expand(x, pending, stage):
     with open(x, 'rb') as x_h:
         for line in x_h.readlines():
             uline = line.decode('utf-8')
+            if '#define DMLC_LOG_STACK_TRACE 1' in uline.strip():
+                # Do not enable stacktrace logging
+                continue
             if uline.find('#include') < 0:
                 out.write(line)
                 continue
@@ -138,10 +148,15 @@ def expand(x, pending, stage):
             m = re1.search(uline)
             if not m:
                 m = re2.search(uline)
-            if not m:
-                print(uline + ' not found')
-                continue
-            path = m.groups()[0]
+            if m:
+                path = m.groups()[0]
+            else:
+                m = re3.search(uline)
+                if m:
+                    path = 'execinfo.h'
+                else:
+                    print(uline + ' not found')
+                    continue
             h = path.strip('./') if "../3rdparty/" not in path else path
             if h.endswith('complex.h') and x.endswith('openblas_config.h'):
                 source = ''

[eric-haibin-lin]

Amalgamation test passed
Thank you @hcho3 !

[hcho3]

Somehow upgrading dmlc-core breaks Julia?