Merge pull request #506 from arcadiaphy/fix_release

Add noexcept in DataIter, InputSplit
dmlc · Mar 2, 2019 · 55f3c7b · 55f3c7b
2 parents 4c5ad9e + 0d55a66
commit 55f3c7b
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 3 deletions.
diff --git a/include/dmlc/common.h b/include/dmlc/common.h
@@ -10,6 +10,7 @@
 #include <string>
 #include <sstream>
 #include <mutex>
+#include <utility>
 #include "./logging.h"
 
 namespace dmlc {

diff --git a/include/dmlc/concurrency.h b/include/dmlc/concurrency.h
@@ -14,6 +14,7 @@
 #include <mutex>
 #include <vector>
 #include <condition_variable>
+#include <utility>
 #include "dmlc/base.h"
 
 namespace dmlc {

diff --git a/include/dmlc/data.h b/include/dmlc/data.h
@@ -56,7 +56,7 @@ template<typename DType>
 class DataIter {
  public:
   /*! \brief destructor */
-  virtual ~DataIter(void) {}
+  virtual ~DataIter(void) DMLC_THROW_EXCEPTION {}
   /*! \brief set before first of the item */
   virtual void BeforeFirst(void) = 0;
   /*! \brief move to next item */

diff --git a/include/dmlc/io.h b/include/dmlc/io.h
@@ -230,7 +230,7 @@ class InputSplit {
     return NextChunk(out_chunk);
   }
   /*! \brief destructor*/
-  virtual ~InputSplit(void) {}
+  virtual ~InputSplit(void) DMLC_THROW_EXCEPTION {}
   /*!
    * \brief reset the Input split to a certain part id,
    *  The InputSplit will be pointed to the head of the new specified segment.

diff --git a/include/dmlc/memory.h b/include/dmlc/memory.h
@@ -7,6 +7,8 @@
 #define DMLC_MEMORY_H_
 
 #include <vector>
+#include <memory>
+#include <utility>
 #include "./base.h"
 #include "./logging.h"
 #include "./thread_local.h"

diff --git a/include/dmlc/optional.h b/include/dmlc/optional.h
@@ -25,7 +25,7 @@ struct nullopt_t {
   explicit nullopt_t(int a) {}
 #else
   /*! \brief dummy constructor */
-  constexpr nullopt_t(int a) {}
+  explicit constexpr nullopt_t(int a) {}
 #endif
 };
 

diff --git a/include/dmlc/thread_group.h b/include/dmlc/thread_group.h
@@ -13,6 +13,8 @@
 #include <mutex>
 #include <set>
 #include <thread>
+#include <memory>
+#include <utility>
 #include <unordered_set>
 #include <unordered_map>
 #if defined(DMLC_USE_CXX14) || __cplusplus > 201103L  /* C++14 */