Add noexcept in DataIter, InputSplit #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcadiaphy thanks for the fix. would you mind also look into the lint errors? |
|
@szha lint is ok |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created in addition to apache/mxnet#14223 and dmlc/mshadow#369 to address memory issues in mxnet exit.
When TensorContainer's destructor becomes noexcept(false), classes that reference it also become noexcept(false) implicitly in destruction.
If inherited class's destructor is noexcept(false) and its base class has a virtual destructor, then base class's destructor should also be added noexcept(false) to successfully compile.