fix lint errors

dmlc · Mar 1, 2019 · 0d55a66 · 0d55a66
1 parent 5834aaf
commit 0d55a66
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/include/dmlc/common.h b/include/dmlc/common.h
@@ -10,6 +10,7 @@
 #include <string>
 #include <sstream>
 #include <mutex>
+#include <utility>
 #include "./logging.h"
 
 namespace dmlc {

diff --git a/include/dmlc/concurrency.h b/include/dmlc/concurrency.h
@@ -14,6 +14,7 @@
 #include <mutex>
 #include <vector>
 #include <condition_variable>
+#include <utility>
 #include "dmlc/base.h"
 
 namespace dmlc {

diff --git a/include/dmlc/memory.h b/include/dmlc/memory.h
@@ -7,6 +7,8 @@
 #define DMLC_MEMORY_H_
 
 #include <vector>
+#include <memory>
+#include <utility>
 #include "./base.h"
 #include "./logging.h"
 #include "./thread_local.h"

diff --git a/include/dmlc/optional.h b/include/dmlc/optional.h
@@ -25,7 +25,7 @@ struct nullopt_t {
   explicit nullopt_t(int a) {}
 #else
   /*! \brief dummy constructor */
-  constexpr nullopt_t(int a) {}
+  explicit constexpr nullopt_t(int a) {}
 #endif
 };
 

diff --git a/include/dmlc/thread_group.h b/include/dmlc/thread_group.h
@@ -13,6 +13,8 @@
 #include <mutex>
 #include <set>
 #include <thread>
+#include <memory>
+#include <utility>
 #include <unordered_set>
 #include <unordered_map>
 #if defined(DMLC_USE_CXX14) || __cplusplus > 201103L  /* C++14 */