Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field verbose_name should use gettext_lazy #1377

Closed
mihalikv opened this issue Jul 7, 2023 · 2 comments · Fixed by #1378
Closed

Field verbose_name should use gettext_lazy #1377

mihalikv opened this issue Jul 7, 2023 · 2 comments · Fixed by #1378
Labels
kind: bug status: accepted status: has patch

Comments

@mihalikv
Copy link

mihalikv commented Jul 7, 2023

Hi,
model field verbose_names should use gettext_lazy, because it creates migrations based on user language settings.

https://github.com/django-cms/django-filer/blob/master/filer/models/foldermodels.py#L9

This is migration generated after upgrade to django-filer 3.0
image

Thanks.
@mihalikv
Copy link
Author

mihalikv commented Jul 7, 2023

Or maybe I am just wrong and it doesn't help, just a guess.

@marksweb
Copy link
Sponsor Member

marksweb commented Jul 7, 2023

@mihalikv No, you're right.

As a general rule;

gettext_lazy() should be used for anything loaded at runtime:

  • models.py (fields, verbose_name, help_text, function short_description);
  • forms.py (labels, help_text, empty_label);
  • apps.py (verbose_name).

gettext()should be used for any modules that are executed during the request process, such as views.py

fsbraun added a commit to fsbraun/django-filer that referenced this issue Jul 7, 2023
@fsbraun
Fix django-cms#1377
accd80c
@fsbraun fsbraun mentioned this issue Jul 7, 2023
Merged
4 tasks
marksweb pushed a commit that referenced this issue Jul 7, 2023
@fsbraun
Fix #1377 (#1378)
ed50e2d
vinitkumar pushed a commit that referenced this issue Jul 12, 2023
@fsbraun
fix: add missing source map files for css (#1383)
4c2b9eb 
* Fix #1377

* add css maps

* fix test requirements

* Update manifest
vinitkumar pushed a commit that referenced this issue Jul 13, 2023
@fsbraun
fix: Allow copy with empty suffix (#1386)
fdd4d64 
* Fix #1377

* Fix: Allow empty suffix in admin copy

* Add submit-row class

* Fix; Cancel link too small if djangocms-admin-style is not present
vinitkumar pushed a commit that referenced this issue Jul 16, 2023
@fsbraun
fix: Do not disable action buttons after using cancel or back button (#…
9c8a5be 
…1391)

* Fix #1377

* fix: After using back button (or cancel button) do not disable action buttons

* Update Changelog
vinitkumar pushed a commit that referenced this issue Jul 21, 2023
@fsbraun
Fix: actions.js error thrown in js console (#1397)
62a843a 
* Fix #1377

* Fix: Avoid actions.js of django admin to throw an error on js console
vinitkumar pushed a commit that referenced this issue Aug 2, 2023
@fsbraun
feat: Update French and Dutch locales (#1407)
b8505d3 
* Fix #1377

* Update French translations

* Add dutch locale

* Update CHANGELOG.rst

* Update CHANGELOG.rst

* Update CHANGELOG.rst
vinitkumar pushed a commit that referenced this issue Aug 4, 2023
@fsbraun
feat: Release 3.0.4 (#1408)
16fcdec 
* Fix #1377

* Bump version

* Complete Spanish locale

* Update CHANGELOG.rst
fsbraun added a commit that referenced this issue Aug 22, 2023
@fsbraun
fix: Respect custom filer and thumbnail storage settings (#1413)
3940e1c 
* Fix #1377

* fix bug #1412

* Fix: differentiate source_storage and thumbnail_storage

* Update tests to run on non-standard storage settings.

* Update CHANGELOG.rst

* Replace `re_path` by `path`

* Remove `re_path` from tests

* Bump version
vinitkumar pushed a commit that referenced this issue Sep 8, 2023
@fsbraun
fix: django-storage 1.14 complains about files being opened twice whe…
68f6aaa 
…n copying (#1418)

* Fix #1377

* Fix: Do not open file twice when moving or copying

* Fix isort folder admin

* no message

* Catch exception raised by django-storage 1.14

* Update filemodels.py

* Update filemodels.py
vinitkumar pushed a commit that referenced this issue Sep 19, 2023
@fsbraun
fix: Unique url names for file icon (#1423)
c3ab24b 
* Fix #1377

* Fix: Ensure uniqueness of admin url names
vinitkumar pushed a commit that referenced this issue Sep 22, 2023
@fsbraun
feat: Add django 5.0 support (#1424)
69893eb 
* Fix #1377

* feat: Django 5.0 compat

* fix github codecov action

* Add tests for action forms.

* Update test

* Remove legacy code, update language files

* Update *.mo

* Update comment

* get_storage_class removed in Django 5
vinitkumar pushed a commit that referenced this issue Sep 30, 2023
@fsbraun
fix: View expanded svg images from <img> tags to avoid js attacks (#…
421c86b 
…1429)

* Fix #1377

* feat: expand images in `<img>` tag to avoid javascript attacks

* Embed in img tags svg only

* Remove canonical url display from directory listing for svg

* Add test

* Remove unused Media class

* Change function of canonical url button

* Remove superflous `} `

* Update NL locale
vinitkumar pushed a commit that referenced this issue Oct 2, 2023
@fsbraun
feat: French translations, prevention of opening SVG directly in brow…
c9872d8 
…ser through canonical url (#1430)

* Fix #1377

* feat: expand images in `<img>` tag to avoid javascript attacks

* Embed in img tags svg only

* Remove canonical url display from directory listing for svg

* Add test

* Remove unused Media class

* Change function of canonical url button

* Remove superflous `} `

* Update NL locale

* Fix: Right click "open in new tab" on canonical url now renders svg in img tag

* Add zoom functionality for expanded svg images

* Fix test and js lint

* More js linting fixes

* Allow ES6

* Update French translations

* Fix css map

* Update filer/templates/admin/filer/image/expand.html

* Fix zoom cursors when displaying svg

* ... second part
fsbraun added a commit that referenced this issue Mar 22, 2024
@fsbraun
fix: Alignment w/ Django 4.2+ admin style (#1453)
011d804 
* Fix #1377

* Fix: styles for django 4.2+ admin

* Fix: Unintended scroll when clearing file widget

* Fix linting errors.
fsbraun added a commit that referenced this issue May 17, 2024
@fsbraun
fix: Folder select widget did not render correctly with standard Djan…
46d7851 
…go admin styles (#1467)

* Fix #1377

* Fix: folder widget css

* Revert "Fix: folder widget css"

This reverts commit 4d5d5d2.

* Disentangle from test changes
fsbraun added a commit that referenced this issue May 21, 2024
@fsbraun @marksweb
fix: File expand url incorrect and worked not with custom image models (
c8af44a 
#1471)

* Fix #1377

* Fix issue #1470

* Update tests

* Update `tox.ini`

* Update tox.ini

Co-authored-by: Mark Walker <[email protected]>

---------

Co-authored-by: Mark Walker <[email protected]>
fsbraun added a commit that referenced this issue Aug 7, 2024
@fsbraun
fix: Allow Image.MAX_IMAGE_PIXELS to be None (#1475)
cce13d2 
* Fix #1377

* fix: `Image.MAX_IMAGE_SIZE = None` allowed.

* Improve warning message

* Add test.
vinitkumar pushed a commit that referenced this issue Aug 22, 2024
@fsbraun
fix: Reduce number of thumbnails created for admin, avoid admin thumb…
f919cbf 
…nails for svg files (#1490)

* Fix #1377

* Simplify admin thumbnails sizes to 40, 80, 160. No thumbnails for svg in the admin.

* Update settings

* Fix undefined variable add_attrs

* Dynamic css for new setting `FILER_THUMBNAIL_ICON_SIZE`

* Replace SVG by icon if larger than 1MB (can be changed by setting)

* Dynamic folder icon size

* Default sizes 40, and 120px

* Update folderadmin.py for better naming
fsbraun added a commit that referenced this issue Aug 25, 2024
@fsbraun
chore: Prepare release 3.2.0 (#1491)
250bd03 
* Fix #1377

* Bump to 3.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug status: accepted status: has patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Use gettext_lazy for folder model verbose names (#1377) fsbraun/django-filer
3 participants
@marksweb @mihalikv @fsbraun