Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View expanded svg images from <img> tags to avoid js attacks #1429

Merged
merged 19 commits into from
Sep 30, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Sep 28, 2023

Description

Directly opening SVG images in the browser is a security issue. Hidden javascript can be executed.
This PR opens SVG using a simple template with a single <img> tag. Other image types are directly sent to the browser.

The canonical URL action button does not open the file in a new browser tab any more for security considerations. Instead the canonical URL is copied to the user's clipboard:

image

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (964f48d) 76.41% compared to head (3068e68) 76.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   76.41%   76.43%   +0.02%     
==========================================
  Files          75       75              
  Lines        3510     3514       +4     
  Branches      562      562              
==========================================
+ Hits         2682     2686       +4     
  Misses        666      666              
  Partials      162      162              
Files Coverage Δ
filer/__init__.py 100.00% <100.00%> (ø)
filer/admin/imageadmin.py 90.38% <100.00%> (+0.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 421c86b into django-cms:master Sep 30, 2023
26 checks passed
@fsbraun fsbraun deleted the fix/expand-image branch September 30, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants