fix(proxy): drive SOCKS5 UI option from runtime ENABLE_SOCKS5_PROXY, not build-time NEXT_PUBLIC (#3508)

[diegosouzapw]

Closes #3508

Problem: the proxy modal gated the SOCKS5 type on NEXT_PUBLIC_ENABLE_SOCKS5_PROXY === "true". Next.js inlines NEXT_PUBLIC_* at build time, so the prebuilt Docker image baked it as false and a runtime NEXT_PUBLIC_ENABLE_SOCKS5_PROXY=true had no effect (the server already honoured the runtime ENABLE_SOCKS5_PROXY, creating a confusing split).

Fix: GET /api/settings/proxies now returns socks5Enabled: ENABLE_SOCKS5_PROXY === "true" (runtime). The modal reads it (with the build-time value as a static-deploy fallback) and computes the proxy-type list + the saved-proxy guards from the live value — so setting ENABLE_SOCKS5_PROXY=true at runtime now surfaces SOCKS5 in the UI. Extracted a pure buildProxyTypes() helper.

Test (Rule #18): tests/unit/proxy-types-socks5-runtime-3508.test.ts (buildProxyTypes include/exclude). typecheck clean; existing ProxyConfigModal vitest suite 3/3.

[gemini-code-assist]

Code Review

This pull request updates the SOCKS5 proxy option to follow the runtime ENABLE_SOCKS5_PROXY environment variable instead of the build-time NEXT_PUBLIC_ENABLE_SOCKS5_PROXY variable, ensuring that prebuilt Docker images respect runtime configuration. It exposes socks5Enabled via the proxy settings API and dynamically determines the available proxy types in the UI. Feedback on the changes includes a recommendation to return a copy of the proxy types array to prevent potential shared mutation, and a request to rewrite the newly added unit tests using Vitest instead of the native Node.js test runner to align with the repository's style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Returning ALL_PROXY_TYPES directly when socks5Enabled is true exposes the module-level constant to potential mutation by callers. To prevent accidental shared mutation, return a new array copy (e.g., using the spread operator).

Suggested change

	export function buildProxyTypes(socks5Enabled: boolean) {
	return socks5Enabled ? ALL_PROXY_TYPES : ALL_PROXY_TYPES.filter((type) => type.value !== "socks5");
	}
	export function buildProxyTypes(socks5Enabled: boolean) {
	return socks5Enabled ? [...ALL_PROXY_TYPES] : ALL_PROXY_TYPES.filter((type) => type.value !== "socks5");
	}

[gemini-code-assist]

To maintain consistency with the repository's standard testing framework (Vitest) and ensure proper integration with test execution and coverage reporting, please use vitest instead of the native Node.js node:test runner and assert module. Also, omit the .tsx extension in the import to follow standard TypeScript module resolution. Finally, update the mutation test to compare two calls with true to verify that a new array reference is indeed returned each time.

import { describe, it, expect } from "vitest";
import { buildProxyTypes } from "../../src/shared/components/ProxyConfigModal";

describe("buildProxyTypes — #3508 runtime socks5 flag", () => {
  it("includes socks5 when socks5Enabled is true", () => {
    const types = buildProxyTypes(true);
    const values = types.map((t) => t.value);
    expect(values).toContain("socks5");
    expect(values).toContain("http");
    expect(values).toContain("https");
  });

  it("excludes socks5 when socks5Enabled is false", () => {
    const types = buildProxyTypes(false);
    const values = types.map((t) => t.value);
    expect(values).not.toContain("socks5");
    expect(values).toContain("http");
    expect(values).toContain("https");
  });

  it("returns a new array each call (no shared mutation)", () => {
    const a = buildProxyTypes(true);
    const b = buildProxyTypes(true);
    expect(a).not.toBe(b);
    expect(a).toHaveLength(3);
    expect(b).toHaveLength(3);
  });
});

References

1. The repository style guide specifies Vitest as the standard testing framework (referencing 'Vitest files' and 'vitest.config.ts'). Tests should use Vitest instead of the native Node.js test runner for consistency. ^(link)

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.