fix: address PR #3518 review comments (lifecycle hooks, regex, indentation, route params)

[oyi77]

Summary

Re-submits the PR #3518 review-comment fixes as a focused 5-file PR per @diegosouzapw's review on #3525. The previous PR was 130+ files (i18n dump + unrelated incidental edits from a stale rebase) with the lifecycle hook forwarding change reverted. This PR is a clean 5-file change off current release/v3.8.20.

What's included (5 files, +45 / -15)

Plugin review fixes (2 files)

• src/lib/plugins/manager.ts — onDeactivate and onUninstall now wrapped in try/catch so a buggy plugin handler can't brick deactivation/uninstall. Redundant outer try/catch around emitHook was removed (the loader's proxy method is the canonical one).
• src/lib/plugins/loader.ts — added lifecycle hook proxy methods (onInstall, onActivate, onDeactivate, onUninstall) that forward via callHook() IPC, same pattern as onRequest/onResponse/onError. Lifecycle hooks are fire-and-forget: errors are logged but don't block deactivation/uninstall.
• src/lib/plugins/hooks.ts — added the four lifecycle hook methods to the Plugin interface.

Other review fixes (3 files)

• open-sse/services/accountFallback.ts — removed 8 redundant RegExp() wrappers around regex literals.
• open-sse/utils/requestLogger.ts — fixed indentation in append() (6 spaces → 4).
• src/app/api/logs/[id]/route.ts — use Next.js params for dynamic route, instead of manual pathname parsing.

What's NOT included (per review)

• ❌ No ~42 docs/i18n/*/CHANGELOG.md dump
• ❌ No package.json × 3 bumps from stale rebase
• ❌ No index.ts 150-line refactor with @deprecated redirect (split out per maintainer request)
• ❌ No chatCore / requestLogger / combo / provider unrelated changes

Verification

• npx tsx --test tests/unit/plugins-loader-ipc.test.ts tests/unit/plugins-loader.test.ts tests/unit/plugins-manager-lifecycle.test.ts tests/unit/plugins-manager.test.ts tests/unit/plugins-edge-cases.test.ts → 95/95 pass (including Plugin interface supports lifecycle hooks)
• npm run check:any-budget:t11 → PASS
• prettier --check → all 5 files pass
• Lifecycle hook proxy methods are tested end-to-end via plugins-loader-ipc.test.ts

[gemini-code-assist]

Code Review

This pull request refactors regex declarations in the account fallback service, fixes indentation in the request logger, and introduces lifecycle hooks (onInstall, onActivate, onDeactivate, onUninstall) to the plugin system. It also refactors the log retrieval route to use route parameters. However, because 'params' is asynchronous in Next.js 15, accessing 'params.id' directly will fail at runtime; you should await 'params' to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

In Next.js 15, params in route handlers is an asynchronous Promise. Accessing params?.id directly without awaiting it will evaluate to undefined at runtime, causing the API to fail with a 400 Missing id error.\n\nTo ensure compatibility with both Next.js 14 and Next.js 15, you should await params before accessing its properties.

Suggested change

	const id = params?.id;
	const id = (await params)?.id;

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

[diegosouzapw]

Thanks @oyi77 — merged into release/v3.8.20. 🙌

The cleanups are solid (redundant RegExp(/.../) → literals, the logs/[id] route now awaits the Next route params instead of hand-parsing the pathname, indentation). The most valuable part is the lifecycle-hook wiring: before this, manager.ts was iterating [onInstall, onActivate, onDeactivate, onUninstall] and calling registerHook(name, loaded.plugin[hookName]), but the loader never built those plugin.onX methods — so they were undefined and the lifecycle hooks were declared-but-dead. Your loader change connects that path.

I added one regression test on your branch (tests/unit/plugins-loader.test.ts, you as author + me as co-author, Hard Rule #18): it asserts loadPlugin builds the declared lifecycle methods and skips undeclared ones, bridging to the worker without throwing. Verified green locally (plugins-loader 7/7, account-fallback 77, requestLogger 41, typecheck:core clean).

Note: there's a separate pre-existing ordering quirk in manager.ts (onInstall is emitted during install() before activate() registers the handler) — out of scope here, flagging for a follow-up.