Repository navigation
fix(dashboard): show a warning, not success, when model import fell back to the local catalog - #15169
Merged
diegosouzapw merged 4 commits intoOct 8, 2026
Conversation
…thor Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
# Conflicts: # src/app/(dashboard)/dashboard/providers/[id]/hooks/modelImportWarning.ts # src/app/(dashboard)/dashboard/providers/[id]/hooks/useModelImportHandlers.ts
diegosouzapw
merged commit Oct 8, 2026
0548149
into
diegosouzapw:release/v3.8.52
27 of 51 checks passed
Owner
|
Thanks @shipsfromrio — merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the model import falls back to the local catalog (the provider's
/modelsendpoint was unreachable) and every model in that catalog is already registered, the import modal ends in the success state with "No new models to import". The user reads that as "the provider's list was checked and nothing is new", while the provider was never reached.Closes #15069
Fix
resolveNoNewModelsPhase()(pure, inmodelImportWarning.ts) returns"warning"when the response carries the fallback warning and"done"only when the remote catalog was actually fetched.useModelImportHandlers.tsuses it in the zero-new-models branch;ImportProgress.phasegains"warning".ImportProgressModal.tsxandProviderModalsPanel.tsxtreat"warning"as a terminal phase (warning icon, close buttons, close handling), so the modal can't get stuck.providers.localCatalogFallbackStatus, added to every locale file.Tests
tests/unit/model-import-fallback-status.test.ts(7 cases): the fallback-with-no-new-models path fails without the fix (it returned"done"), plus the helper cases and a check that the new key exists inen.json.