Repository navigation
fix(api): expose per-member supportsVision on /v1/combos model steps (#14587) - #15823
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14587
Root cause
The core of #14587 (vision override honored, MiMo id fragments) already landed via #14595 / #15086;
getResolvedModelCapabilitiesnow agrees with routing on themodelCompatOverrides.supportsVisionrow (covered bytests/unit/model-compat-vision-canonical-resolution-14587.test.ts). What remained was diagnosability:/v1/combosonly exposed the aggregatecapabilities.multimodal, so an operator could not tell which member blocks it.Fix
PublicComboStepgainssupportsVision?: boolean | null(true/false/null= no source knows), set on directmodelsteps when capabilities are included, using the same resolver (and bulk snapshot) as the aggregate. No behavior change tomultimodal.docs/openapi.yamldocuments the field onGET /api/v1/combos.Tests
tests/unit/14587-combo-member-supports-vision.test.ts(new): per-member verdicts, invariantmultimodal === every(member.supportsVision === true), field omitted without capabilities.v1-combos-projection(14),model-compat-vision-canonical-resolution-14587(6).Gates
eslint (with suppressions) exit 0, prettier,
typecheck:coreexit 0, check-complexity OK (3003 < 3218), check-cognitive-complexity OK (1374 < 1437), check-file-size no violations, husky pre-commit gates passed.