fix(ci): make Merge integrity green — a bulletless changelog fragment and a stale generated skill - #12923
fix(ci): make Merge integrity green — a bulletless changelog fragment and a stale generated skill#12923ntdat812 wants to merge 2 commits into
Conversation
check:changelog-integrity fails on release/v3.8.51 itself: changelog.d/fixes/reset-aware-model-family.md is a bare sentence with no "- " bullet, so the Merge integrity gate is red on every open pull request, not just the one that added it. Restores the bullet in the repo's format with the credit to @HouMinXi, and renames the file to the documented <PR-number>-<slug> convention so aggregation order stays deterministic.
check:agent-skills-sync is the other half of the Merge integrity gate and it is also failing on release/v3.8.51 itself: the committed SKILL.md documents 'tunnel create [type]' while the generator reads 'tunnel create' from the CLI definition. Regenerated with --apply; no hand edits.
|
Verified locally on the current tip — both halves of
Node v26.4.0. Every open PR against the branch currently inherits that |
|
Both issues here were real when opened, but the ground shifted under this PR: the changelog Triage note: this is the review recommendation — the close itself happens only after the maintainer's per-PR sign-off (and, where a superseding PR is named, after it has landed). Nothing is being closed by this comment. |
|
Obrigado, mas esta não pode entrar — ela reverteria duas coisas que o tip já corrigiu, e uma delas é superfície de instrução de agente. 1. E o diff desta PR faz o caminho inverso:
2. Fechando. O problema de "Merge integrity" que motivou a PR era real quando você a abriu; ele foi resolvido por outro caminho (#13216) enquanto ela esperava. Se ainda vir o gate vermelho no tip atual, reabra com a saída do gate que você está vendo — aí investigo de novo. |
release/v3.8.51fails its own Merge integrity (changelog + generated skills) gate, so every open pull request inherits a red check that has nothing to do with its diff. The gate has two halves and both are failing on the base branch. One PR fixes both, because fixing either alone leaves the check red.Half 1 — a changelog fragment with no bullet
The file is a bare sentence. It arrived with
2a6eff0aec(#12637, @HouMinXi, 3 Sep), and because the gate scans the wholechangelog.d/tree rather than only the fragments a PR touches, one malformed file turns the check red for everybody.Restored as the bullet the other fragments use, wording unchanged apart from an article, credit kept:
Also renamed to
12637-reset-aware-model-family.md, sincechangelog.d/README.mdspecifies<PR-number>-<short-slug>.mdand says the prefix is what keeps aggregation order deterministic. Happy to drop the rename if you would rather keep a fix like this to one line.Half 2 — a generated skill that drifted from the CLI
skills/cli-tunnel/SKILL.mddocumentstunnel create [type]; the generator readstunnel createfrom the current CLI definition. Two lines, and the file was never regenerated after the argument changed. Regenerated with--apply, no hand edits.Verification
Both halves, before and after, on a clean tree:
There is no unit test to add: the gate that was failing is the test, and it goes red → green on this diff. Nothing outside those two files is touched.
I have not checked whether either drift is present on other release branches; if they were cherry-picked, the same two fixes apply there.