feat(dashboard): orchestration canvas fase 3 — compare two runs in the History tab (2.9) - #12677
Merged
Merged
Conversation
…nd, ARIA level Final-review fix wave for PR-A (Orchestration Canvas Fase 3): - Give each compare-panel side an explicit fetch status (loading/ok/error) so the Events metrics row shows "—" instead of a misleading real "0"/delta while a side is still loading or after its fetch failed. - Bound the compare panel's height (max-h-[45vh], overflow-y-auto, shrink-0) so a run with many activities can no longer collapse the History grid to zero height. - Clear the compare selection when the History preset changes, since a stale pick can fall outside the new range. - Add a delta-column legend (new compareDeltaLegend i18n key, translated into all 41 non-English locales) so operators know which side a positive delta favors. - Use role="status" (not role="alert") for the informational compareDifferentIdentity banner, reserving role="alert" for actual per-side fetch failures. - Restore ro.json's compareCost to the true cognate "Cost" (was distorted to "Cheltuieli" to dodge a byte-identical-to-English heuristic); audited the other 40 locales for the same pattern across the 9 compare* keys, no other instance found.
diegosouzapw
force-pushed
the
feat/orch-fase3-a
branch
from
September 4, 2026 06:37
b51c534 to
596f528
Compare
Owner
Author
|
Held, not reviewed — Hard Rule #22b.
No action taken and nothing touched on the branch. Ping me once that worktree is torn down and I will pick it up in the next batch. |
…r complexity ratchets CompareRunsPanel (92 lines, max-lines-per-function) and HistoryTab (85 lines, same rule) exceeded the 80-line function cap; compareRuns.ts's a2aEventsFrom exceeded the cognitive-complexity cap (16 > 15). Extract pure/presentational helpers (ComparePanelHeaderBar, SideErrorRow, ComparisonMetrics, a2aEventFrom, HistoryStatusRows, refreshNowMsOnActionDone) with no behavior, DOM, i18n or aria change.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…e History tab (2.9) (diegosouzapw#12677) * feat(dashboard): pure model to compare two orchestration runs * feat(dashboard): compare-mode selection in the History grid * feat(dashboard): side-by-side comparison panel in the History tab (2.9) * chore(dashboard): compare-runs i18n + changelog * fix(dashboard): compare-panel loading state, height bound, delta legend, ARIA level Final-review fix wave for PR-A (Orchestration Canvas Fase 3): - Give each compare-panel side an explicit fetch status (loading/ok/error) so the Events metrics row shows "—" instead of a misleading real "0"/delta while a side is still loading or after its fetch failed. - Bound the compare panel's height (max-h-[45vh], overflow-y-auto, shrink-0) so a run with many activities can no longer collapse the History grid to zero height. - Clear the compare selection when the History preset changes, since a stale pick can fall outside the new range. - Add a delta-column legend (new compareDeltaLegend i18n key, translated into all 41 non-English locales) so operators know which side a positive delta favors. - Use role="status" (not role="alert") for the informational compareDifferentIdentity banner, reserving role="alert" for actual per-side fetch failures. - Restore ro.json's compareCost to the true cognate "Cost" (was distorted to "Cheltuieli" to dodge a byte-identical-to-English heuristic); audited the other 40 locales for the same pattern across the 9 compare* keys, no other instance found. * refactor(dashboard): split compare-runs/history-tab functions to clear complexity ratchets CompareRunsPanel (92 lines, max-lines-per-function) and HistoryTab (85 lines, same rule) exceeded the 80-line function cap; compareRuns.ts's a2aEventsFrom exceeded the cognitive-complexity cap (16 > 15). Extract pure/presentational helpers (ComparePanelHeaderBar, SideErrorRow, ComparisonMetrics, a2aEventFrom, HistoryStatusRows, refreshNowMsOnActionDone) with no behavior, DOM, i18n or aria change. --------- Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orchestration Canvas — Fase 3 / PR-A: comparar duas execuções (item 2.9)
Primeira das quatro PRs da Fase 3. Única feature nova da fase — as outras três são dívida catalogada.
O que entra
model/compareRuns.ts: recebe doisHistoryIteme seus detalhes, devolve os dois lados normalizados mais os deltas com sinal. Sem React, sem fetch. Leitura defensiva por construção: o detalhe vem de JSON e, no caso do A2A, demetadataque o cliente envia sem validação — item malformado é descartado, lista ausente vira vazia, a função nunca lança.Cuidados que a review final exigiu
—, não zero. Duração e custo continuam visíveis porque vêm do próprio item do grid, não da busca.Invalid Date; alerta só no lado que realmente falhou; aviso de identidades diferentes érole="status", nãorole="alert".Validação
sameIdentity, detalhe malformado sem lançar) e vitest do modo e do painel — incluindo testes provados capazes de falhar se o conserto for revertido.typecheck:core,check:dashboard-typecheck,test:vitest,check:cyclesei18n-vi-completenessverdes.O gate local
lintacusa supressões obsoletas herdadas da base (arquivo não tocado por esta PR).Spec:
_tasks/superpowers/specs/2026-09-03-orchestration-canvas-fase3-design.md§2 (privado). Seguem PR-B (#12392), PR-C (#12639) e PR-D (#12378).Todo o vermelho desta PR vem do tip de
release/v3.8.51, não do diff dela. Rastreio por job:open-sse/executors/glm.tsTS2554 (aridade do buffer de stream)Os gates próprios desta PR (typecheck do dashboard, lint, testes de
compareRuns/CompareRunsPanel/HistoryTab) passam localmente.