Skip to content

fix(pack): allow the opencode-plugin-v2 workspace package in the artifact policy (base-red) - #12929

Closed
guanbear wants to merge 3 commits into
diegosouzapw:release/v3.8.51from
guanbear:fix/restore-stream-highwatermark
Closed

guanbear wants to merge 3 commits into
diegosouzapw:release/v3.8.51from
guanbear:fix/restore-stream-highwatermark

Conversation

@guanbear

@guanbear guanbear commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary (scope updated)

The release wave around #12870 added @omniroute/opencode-plugin-v2/* to the npm pack artifact but never registered its prefix in PACK_ARTIFACT_ROOT_ALLOWED_PATH_PREFIXES, so the pack-policy gate fails on the release tip for every open PR. This adds the one-line prefix entry alongside the existing v1 @omniroute/opencode-plugin/.

History

This PR originally carried the full set of release-tip base-reds (stream highWaterMark restoration, chatCore union narrowing, doc count drift). The maintainers have since landed equivalents themselves — #12963 (pin the ok variant), #12970 (sync migration/strategy counts), and the non-streaming-leg restore wave — so those commits are dropped from this branch and all that remains is the still-unfixed pack policy entry.

Validation

  • validate-pack-artifact.ts --policy-only → ✅ pass (fails on the release tip).
  • Full gate suite on this tree: api-typecheck / open-sse-typecheck / file-size / docs-sync / changelog-integrity all OK (inherited from the tip plus the one policy line).

@guanbear

guanbear commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Updated this base-red fix to keep every gate green on its own tree:

  • The restoration is compacted to +1 line against the stream.ts cap (no doc line on the StreamOptions field, default inlined at both strategy entries, and the createPassthroughStreamWithLogger half is not restored — its only caller passes 11 args). Cap raised 3072→3073 with a justified baseline note per the documented last resort.
  • Also bundled two further base-reds blocking every open PR: stale migration counts (README/AGENTS.md/llm.txt said 169, code has 170 — llm.txt propagated to all 41 locale mirrors) and the reset-aware-model-family changelog fragment missing its markdown bullet.

Local validation on this tree: api-typecheck OK (289 within baseline), open-sse-typecheck OK (0), file-size OK, docs-sync/docs-counts/changelog-integrity OK, pack-policy OK, mutation-test-coverage OK, and the GLM + stream/SSE suites (153 tests) pass. #12893 carries the same commits as cherry-picks so its CI can go green in parallel.

…fact policy (base-red)

diegosouzapw#12870 added @omniroute/opencode-plugin-v2 to the npm pack artifact but
did not register its prefix in PACK_ARTIFACT_ROOT_ALLOWED_PATH_PREFIXES,
so the pack-policy gate fails on the release tip for every open PR.
@guanbear
guanbear force-pushed the fix/restore-stream-highwatermark branch from dacb1c3 to 38274c1 Compare September 9, 2026 13:37
@guanbear guanbear changed the title fix(stream): restore the highWaterMark plumbing dropped from #12506 (base-red) fix(pack): allow the opencode-plugin-v2 workspace package in the artifact policy (base-red) Sep 9, 2026
@guanbear

guanbear commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and narrowed: the upstream fixes (#12963, #12970, #12990) covered the stream/chatCore/docs base-reds this PR originally carried, so the branch now contains only the pack-policy allowlist entry that is still red on the tip.

@guanbear

Copy link
Copy Markdown
Contributor Author

Same treatment: merged the current tip and re-synced the migration count (171→172) so CI runs on a fresh tree. Remaining red on the tip (volcengine no-explicit-any ESLint errors from #12950) is unrelated to this one-line change.

@diegosouzapw

Copy link
Copy Markdown
Owner

Good catch on the missing allowlist entry — the pack-policy gap was real. It ended up landing
on the tip through a separate maintenance sweep (#12959) that independently added the same
@omniroute/opencode-plugin-v2/ line, alongside the doc-count half of this PR (which had
since gone stale — the tip moved past the 172 you targeted). Closing as already covered.

Triage note: this is the review recommendation — the close itself happens only after the maintainer's per-PR sign-off (and, where a superseding PR is named, after it has landed). Nothing is being closed by this comment.

@diegosouzapw diegosouzapw added the protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge label Sep 15, 2026
@guanbear

Copy link
Copy Markdown
Contributor Author

Closing as already covered — thanks for confirming the gap was real and for landing it via the #12959 maintenance sweep (same allowlist line, plus the fresher doc counts). Nothing left to carry here.

@guanbear guanbear closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants