fix(guardrails): pass providerId to getResolvedModelCapabilities in checkComboVision (#12112) - #12169
Merged
diegosouzapw merged 4 commits intoSep 1, 2026
Conversation
…heckComboVision (diegosouzapw#12112) Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
added a commit
that referenced
this pull request
Sep 1, 2026
…12248) Merging --admin with red discrimination (merge-gates §4). The only failing check is Fast Quality Gates → `mutation-test-coverage`, which cannot be caused by this PR: the diff touches exactly one file, `CLAUDE.md` (13 deleted lines, zero .ts). The same gate is red on #12166, #12167 and #12169 — three unrelated PRs — confirming inherited base drift rather than a PR-introduced defect.
Refresh the complexity-ratchets merge-base so new-code mode only sees this PR's files. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Owner
Sweep-reds Fase B (round 2)Merged The previous FQG failure listed regressions in Waiting on a fresh FQG run. No production-code change in this merge. |
…ude diegosouzapw#12288) Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…w#11770)" (diegosouzapw#12248) Merging --admin with red discrimination (merge-gates §4). The only failing check is Fast Quality Gates → `mutation-test-coverage`, which cannot be caused by this PR: the diff touches exactly one file, `CLAUDE.md` (13 deleted lines, zero .ts). The same gate is red on diegosouzapw#12166, diegosouzapw#12167 and diegosouzapw#12169 — three unrelated PRs — confirming inherited base drift rather than a PR-introduced defect.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…heckComboVision (diegosouzapw#12112) (diegosouzapw#12169) * fix(guardrails): pass providerId to getResolvedModelCapabilities in checkComboVision (diegosouzapw#12112) Signed-off-by: Minxi Hou <houminxi@gmail.com> * chore(quality): register combo-vision providerId test in the stryker tap set --------- Signed-off-by: Minxi Hou <houminxi@gmail.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12112.
checkComboVision(getComboVisionBridgeDecision) and combo compatibility predicates inopen-sse/services/combo/comboStructure.ts(isVisionIncompatibleTarget,hasKnownCompatibleContextLimit,getTargetCompatibilityFailures) previously resolved model capabilities passing only the bare model string (e.g.targetModelortarget.modelStr), dropping theproviderId/provider. For steps targeting namespaced models with slashes (e.g.{ providerId: "nvidia", model: "nvidia/nemotron-nano-12b-v2-vl" }), the capabilities resolver receivedprovider: nulland failed to match the model in the provider capability registry (supportsVision: true), causing false-negative capability evaluations and erroneously grading vision combos asno-vision.Changes
src/lib/guardrails/visionBridge.ts: IngetComboVisionBridgeDecision, resolve capabilities passing{ provider: s.providerId || s.provider || null, model: targetModel }.open-sse/services/combo/comboStructure.ts: Pass structured descriptor{ provider: target.providerId || target.provider || null, model: target.modelStr }togetResolvedModelCapabilitiesacrosshasKnownCompatibleContextLimit,isVisionIncompatibleTarget, andgetTargetCompatibilityFailures.tests/unit/guardrails/combo-vision-provider-id-12112.test.ts: Dedicated test suite verifying that namespaced models withproviderIdresolve vision capability correctly.Verification
npm run typecheck:core: 0 errors.npm run check:cycles: PASS (no cycles).node --test tests/unit/guardrails/combo-vision-provider-id-12112.test.ts tests/unit/combo-vision-*.test.ts: 9/9 PASS.