Skip to content

chore(ci): unblock quality gates - env-doc sync + stryker tap.testFiles registration (#9282) - #11609

Merged
diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
Meet6338-X:ci/9282-unblock-quality-gates
Aug 26, 2026
Merged

diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
Meet6338-X:ci/9282-unblock-quality-gates

Conversation

@Meet6338-X

Copy link
Copy Markdown
Contributor

What

Unblocks two of the six red Quality Gates repo-wide, using the gate outputs themselves as the spec. Evidence base: log-level triage of PR #11579's run (jobs 98041152112 / 98041152156), posted as this comment. Refs #9282.

1. .env.example — document OMNIROUTE_CORPUS_CACHE_SIZE

check:env-doc-sync (Docs Gates fast-path) fails with:

? In code but missing from .env.example: 1
   - OMNIROUTE_CORPUS_CACHE_SIZE

The var is a real user-facing tunable: the local-corpus LRU index cache size (src/lib/localCorpus/configured.ts, default 5). Added a documented section following the file's existing conventions (# Used by: + commented default).

2. stryker.conf.json — register 2 missing tap.testFiles

check:mutation-test-coverage --strict (Fast Quality Gates) fails on exactly:

src/server/authz/routeGuard.ts
    + tests/unit/authz/route-guard-tunnel-processes-local-only.test.ts
open-sse/services/combo/quotaScoring.ts
    + tests/unit/universal-quota-aware-routing.test.ts
open-sse/services/combo/quotaStrategies.ts
    + tests/unit/universal-quota-aware-routing.test.ts

Both files exist on the release branch; registered in alphabetical position (tap.testFiles 344 → 346). No other key touched — diff is textual, byte-style preserved.

Expected effect

With this landed on release/v3.8.51, Docs Gates (fast-path) and the mutation-test-coverage --strict sub-gate go green for every open PR, and Fast Quality Gates drops from 2 failed sub-gates to 1 (known-symbols).

Still red after this (needs separate work — flagged for triage)

Gate Cause Why not here
No new ESLint warnings leftover suppression-file entries ("suppressions left that do not occur anymore" → exit 2) pruning requires running lint against the tree; mechanical but must be generated, not hand-edited
Fast Quality Gates known-symbols: 142 executor aliases (incl. core built-ins like github, kiro, bedrock) don't resolve to a valid BaseExecutor registry/catalog drift in gate context — needs an owner who knows the executor bootstrap
Unit shards copilot token-health classification (github_access_token_invalid ≠ invalid_grant) and ts7 tools truncation (200 !== 128) + db-cleanup/cursor-renewal/etc. set real behavior-vs-test divergences in unrelated modules; each needs an intent call

Refs #9282 · Related PRs currently blocked by these gates: #11579, #11598, #11577, #11580, #11582.

…ation (diegosouzapw#9282)

Gate-log evidence from PR diegosouzapw#11579's run (job IDs 98041152112/52132/52156):

- check:env-doc-sync fails on OMNIROUTE_CORPUS_CACHE_SIZE being read in
  src/lib/localCorpus/configured.ts but absent from .env.example.
  Document it as the user-facing tunable it is.

- check:mutation-test-coverage --strict fails on 3 covering tests
  missing from stryker.conf.json tap.testFiles:
    tests/unit/authz/route-guard-tunnel-processes-local-only.test.ts
      (covers src/server/authz/routeGuard.ts)
    tests/unit/universal-quota-aware-routing.test.ts
      (covers combo/quotaScoring.ts + combo/quotaStrategies.ts)
  Register both, exactly as the gate output prescribes.

Remaining red gates NOT addressable by this diff (documented for
triage): eslint suppression-file prune (needs a lint run), known-symbols
executor-registry drift (142 unresolved aliases), and two unrelated
unit regressions (copilot token-health classification; ts7 tools
truncation 200!=128).

Refs diegosouzapw#9282
…#11444

OpencodeExecutor must NOT truncate tool lists (chatCore
truncateToolList owns limiting per toolLimitDetector). The old guard
contradicted opencode-tools-no-truncation.test.ts and failed every
unit shard run (200 !== 128).

Removes only the contradicting it() block; the remaining TS7
narrowing guards are untouched. A pointer comment keeps the history
discoverable.

Refs diegosouzapw#9282
# Conflicts:
#	stryker.conf.json
#	tests/unit/ts7-executor-shared-shapes.test.ts
@diegosouzapw
diegosouzapw merged commit 18d5b75 into diegosouzapw:release/v3.8.51 Aug 26, 2026
0 of 3 checks passed
diegosouzapw pushed a commit that referenced this pull request Aug 26, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — #11580/#11582/#11583/#11585/#11588/#11589/#11590/#11591/#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…es registration (diegosouzapw#9282) (diegosouzapw#11609)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). Dois conflitos, ambos triviais: (1) stryker.conf.json — mesma linha com indentação diferente, mantida a indentação correta; (2) ts7-executor-shared-shapes.test.ts — mesma correção já coberta por diegosouzapw#11591/diegosouzapw#11608 (mergeados neste lote), mantido o describe/comentário melhor deste PR sobre a asserção já validada. Validado: 4/4 testes passando. Obrigado pela contribuição.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…osouzapw#11608)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — diegosouzapw#11580/diegosouzapw#11582/diegosouzapw#11583/diegosouzapw#11585/diegosouzapw#11588/diegosouzapw#11589/diegosouzapw#11590/diegosouzapw#11591/diegosouzapw#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants