Skip to content

fix(ci): resolve inherited release/v3.8.51 base-red CI failures - #11608

Merged
diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
jonlwheat2-gif:jonlwheat2-gif-release-v3-8-51-basereds
Aug 26, 2026
Merged

diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
jonlwheat2-gif:jonlwheat2-gif-release-v3-8-51-basereds

Conversation

@jonlwheat2-gif

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #11449

Fixes all 10 inherited CI failures on release/v3.8.51 that block PR #11567. The PR's own objective (typecheck:core) passes; every failing job here is inherited from the base branch.

Fixes

  1. env-doc-sync — documented OMNIROUTE_CORPUS_CACHE_SIZE in .env.example and docs/reference/ENVIRONMENT.md (commit d6fd55c).
  2. route-guard exemptions — LOCAL_ONLY_API_GET_EXEMPTIONS legitimately has 2 entries now (/api/system/version + /api/tunnels/cloudflared fix(authz): restrict tunnel process routes locally #11531); test updated and doc comment expanded (d6fd55c).
  3. known-symbols — test fixture matches the typed const lazyExecutors: Record<...> declaration (d6fd55c).
  4. mutation-test-coverage — registered route-guard + quotaScoring/quotaStrategies test files in stryker.conf.json (d6fd55c).
  5. bundler flag — resolveNextBuildBundlerFlag now defaults to --turbopack; test updated (d6fd55c).
  6. pack-artifact — added bin/cli/utils/volatileEnvPath.mjs to PACK_ARTIFACT_REQUIRED_PATHS (d6fd55c).
  7. Vietnamese locale — filled 5 remaining translations, removing ___ markers/empty fallbacks (d6fd55c).
  8. checkConnection Copilot boundary — restored fix(resilience): credits_exhausted providers still consume CPU despite cooldown config #8182: GitHub access-token-only connections expired for a non-no_refresh_token reason stay terminal (2af5854).
  9. OpencodeExecutor truncation — tools array passes through intact (truncation now lives in chatCore); stale test updated (d6fd55c).
  10. qwen-cloud-token-plan resolvedModel — qwen-cloud-token-plan/qwen-web serve bare qwen3.8-max (no -preview rewrite); test updated to per-provider expectation (d6fd55c).

Verification

npm run typecheck:core          # exit 0
npm run lint                    # only pre-existing stale-suppressions notice (owned by #11567)
node --import tsx/esm --test <9 changed test files>   # 87/87 pass
npm run test:coverage           # coverage 84.45% statements / 79.37% branches / 87.75% functions / 84.45% lines (all >= 60%)

Coverage note

test:coverage exits non-zero only due to pre-existing, Windows-environment-specific failures inherited from the base branch (cert store query, zcode-executor EPERM temp cleanup, adobe-firefly, api-key-lifecycle, auggie CLI spawning, binaryManager symlink/rollback). None relate to these 10 fixes; all changed test files pass. Coverage itself is well above the 60/60/60/60 floor.

Off-limits (owned by PR #11567)

  • open-sse/translator/response/openai-responses/pureHelpers.ts
  • config/quality/eslint-suppressions.json

jonlwheat2-gif and others added 2 commits August 26, 2026 00:07
…ed connections

The generic retry-budget exemption (isRecoverableExpiredWithRetryBudget) was
accidentally widening the diegosouzapw#8182 boundary: GitHub access-token-only connections
expired for a non-no_refresh_token reason (e.g. invalid_grant) were being kept
eligible for probes instead of remaining terminal.

Exclude GitHub access-token-only connections from the generic retry-budget
exemption. Only the dedicated isRecoverableGithubCopilotNoRefresh path (exact
no_refresh_token shape) self-heals those connections.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Align tests, config, and docs with intentional base-branch behavior changes:

- env-doc-sync: document OMNIROUTE_CORPUS_CACHE_SIZE in .env.example + ENVIRONMENT.md
- route-guard: LOCAL_ONLY_API_GET_EXEMPTIONS now has 2 entries (cloudflared GET diegosouzapw#11531)
- known-symbols: fixture matches typed const lazyExecutors declaration
- mutation-test-coverage: register routeGuard + quotaScoring/quotaStrategies test files
- bundler flag: resolveNextBuildBundlerFlag now defaults to --turbopack
- pack-artifact: include bin/cli/utils/volatileEnvPath.mjs
- i18n: fill remaining Vietnamese translations (no ___ markers/empty fallbacks)
- opencode executor: tools array passes through intact (truncation moved to chatCore)
- qwen model alias: qwen-cloud-token-plan/qwen-web serve bare qwen3.8-max (no -preview rewrite)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
diegosouzapw pushed a commit that referenced this pull request Aug 26, 2026
…es registration (#9282) (#11609)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). Dois conflitos, ambos triviais: (1) stryker.conf.json — mesma linha com indentação diferente, mantida a indentação correta; (2) ts7-executor-shared-shapes.test.ts — mesma correção já coberta por #11591/#11608 (mergeados neste lote), mantido o describe/comentário melhor deste PR sobre a asserção já validada. Validado: 4/4 testes passando. Obrigado pela contribuição.
# Conflicts:
#	scripts/build/pack-artifact-policy.ts
#	src/i18n/messages/vi.json
#	tests/unit/authz/route-guard-version-get-exemption.test.ts
#	tests/unit/bun-support.test.ts
#	tests/unit/check-known-symbols.test.ts
#	tests/unit/qwen38-max-bare-id-alias.test.ts
#	tests/unit/ts7-executor-shared-shapes.test.ts
@diegosouzapw
diegosouzapw merged commit 1d476e4 into diegosouzapw:release/v3.8.51 Aug 26, 2026
4 of 7 checks passed
diegosouzapw added a commit to HouMinXi/OmniRoute that referenced this pull request Aug 29, 2026
…in after merge

Merging origin/release/v3.8.51 showed the skip assertion from diegosouzapw#11611 no
longer matches production: GitHub access-token-only expired connections
with remaining retry budget are probed via refreshCopilotToken (fetch is
called; lastHealthCheckAt is set). That boundary was pinned by diegosouzapw#11592
after the diegosouzapw#11608 carve-out. Keep the probe assertion.

Refs diegosouzapw#11611 diegosouzapw#11592

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…es registration (diegosouzapw#9282) (diegosouzapw#11609)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). Dois conflitos, ambos triviais: (1) stryker.conf.json — mesma linha com indentação diferente, mantida a indentação correta; (2) ts7-executor-shared-shapes.test.ts — mesma correção já coberta por diegosouzapw#11591/diegosouzapw#11608 (mergeados neste lote), mantido o describe/comentário melhor deste PR sobre a asserção já validada. Validado: 4/4 testes passando. Obrigado pela contribuição.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…osouzapw#11608)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — diegosouzapw#11580/diegosouzapw#11582/diegosouzapw#11583/diegosouzapw#11585/diegosouzapw#11588/diegosouzapw#11589/diegosouzapw#11590/diegosouzapw#11591/diegosouzapw#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants