fix(pack): register bin/cli/utils/volatileEnvPath.mjs as a required artifact path (#11437) - #11588
Merged
diegosouzapw merged 3 commits intoAug 26, 2026
Conversation
…rtifact path (diegosouzapw#11437) `Unit Tests fast-path` is red on every branch: ✖ every bin/omniroute.mjs local import is enforced by check:pack-artifact add bin/<file> to PACK_ARTIFACT_REQUIRED_PATHS: cli/utils/volatileEnvPath.mjs diegosouzapw#11437 (`943b9aaa8`) added import { describeVolatileEnvWarning } from "./cli/utils/volatileEnvPath.mjs"; to `bin/omniroute.mjs` without registering the file. That list is not decoration: as its own comment says, `bin/cli/` is only an allowlist PREFIX, so a file vanishing from the tarball never trips the unexpected-paths check — only a required entry makes its absence loud. Without it, the prune could drop a module the published CLI imports on every boot and the failure would first appear as a crash on a user's machine. Same diegosouzapw#7065 class as the `tls-options` / `head-response-guard` entries above it.
…aths list The previous commit added bin/cli/utils/volatileEnvPath.mjs to PACK_ARTIFACT_REQUIRED_PATHS but left the hardcoded expectation in "findMissingArtifactPaths flags missing root runtime files in the tarball" untouched, so that test failed on the new entry. The golden list is the point of that test — it is what makes an accidental removal from the policy visible — so the fix is to extend it, not to derive it from the constant under test.
Contributor
Author
|
Follow-up in I extended the golden list rather than deriving it from the constant under test: the literal list is what makes an accidental removal from the policy visible, and deriving it would make the assertion vacuous. Worth knowing for future entries: every addition to |
diegosouzapw
merged commit Aug 26, 2026
f40f6e1
into
diegosouzapw:release/v3.8.51
10 of 16 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 26, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — #11580/#11582/#11583/#11585/#11588/#11589/#11590/#11591/#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…rtifact path (diegosouzapw#11437) (diegosouzapw#11588) Merged via /merge-batch (lote 2026-08-26, v3.8.51). Boarded no worktree combinado junto com outras ~30 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e ~370 testes focados (unit + vitest) passando. Obrigado pela contribuição.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…osouzapw#11608) Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — diegosouzapw#11580/diegosouzapw#11582/diegosouzapw#11583/diegosouzapw#11585/diegosouzapw#11588/diegosouzapw#11589/diegosouzapw#11590/diegosouzapw#11591/diegosouzapw#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the "every gate is red on every branch" cleanup — one of six independent unit-test failures on
release/v3.8.51.The red test
Cause
#11437 (
943b9aaa8— the commitissue #11449 names as the offending push range) added to
bin/omniroute.mjs:without registering the file in
PACK_ARTIFACT_REQUIRED_PATHS.Why the list matters
This is not bookkeeping. The list's own comment says it:
assembleStandalonecopies wrappers to the dist root and the prepublish prune deletesanything not allowlisted. A
bin/cli/file is inside a prefix, so its disappearance issilent — and
describeVolatileEnvWarningis called on every CLI boot, so the firstsymptom would be a crash on a user's machine after
npm i -g omniroute. Exactly the#7065 class the
tls-optionsandhead-response-guardentries directly above it existto prevent.
Verification
Two added lines, no code change.