test: local ICP Ninja example deployment#217
Merged
Conversation
lpahlavi
changed the title
gregorydemay
approved these changes
Sep 2, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks a lot @lpahlavi for this PR!
.github/workflows/ci.yml
Outdated
| echo "$out" | grep -E "[1-9A-HJ-NP-Za-km-z]{32,44}" > /dev/null || { echo "❌ Call to 'solana_account' failed"; exit 1; } | ||
| out=$(dfx canister call basic_solana get_balance --output json) | ||
| echo "$out" | ||
| echo "$out" | grep -E "[0-9]+(?:_[0-9]+)*" > /dev/null || { echo "❌ Call to 'get_balance' failed"; exit 1; } |
Contributor
There was a problem hiding this comment.
nit: there might be a problem with the grep since the job issues a warning
grep: warning: ? at start of expression
Contributor
Author
There was a problem hiding this comment.
Very good catch! Turns out this is PCRE regex syntax for a non-capturing group, but we need POSIX syntax which doesn't support that. I've removed it (both in the icp-ninja-tests and ent-to-end-tests steps) as it's unnecessary for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(XC-454) Test local deployment of ICP Ninja
basic_solanaexample. This simulates what a user would do when downloading their project from ICP Ninja and deploying it locally. This includes downloading the latest SOL RPC canister WASM file from GitHub and changing the value ofsolana_networkin theinit_argsindfx.jsonfromDevnettoCustom = record { url = \"https://api.devnet.solana.com\"; headers = null }as outlined in thebasic_solanaREADME.