Skip to content

test: local ICP Ninja example deployment #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpahlavi merged 9 commits into from
Sep 2, 2025
Merged

test: local ICP Ninja example deployment #217

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8f4dd7
XC-454: Test ICP Ninja deployment locally
lpahlavi Aug 28, 2025
ff8adb0
XC-454: Use free Solana RPC provider
lpahlavi Aug 28, 2025
aba25ac
XC-454: Fix typo in `ci.yml`
lpahlavi Aug 28, 2025
39dc1a0
XC-454: Revert change to `dfx.json`
lpahlavi Aug 28, 2025
18f6f5d
XC-454: Escape characters
lpahlavi Aug 28, 2025
95272e6
XC-454: Add debug print
lpahlavi Aug 28, 2025
bcfdc1a
XC-454: Single backslash escape in `sed` command
lpahlavi Aug 28, 2025
42d0732
XC-454: Remove debug print
lpahlavi Aug 28, 2025
8d4e314
XC-454: Use POSIX ERE and quiet mode in grep balance check
lpahlavi Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,37 @@ jobs:
- name: 'Run unit tests'
run: cargo test --locked --workspace --exclude basic_solana --exclude sol_rpc_int_tests --exclude sol_rpc_e2e_tests

icp-ninja-tests:
runs-on: ubuntu-latest
steps:
- name: 'Checkout'
uses: actions/checkout@v4

- name: 'Install dfx'
uses: dfinity/setup-dfx@e50c04f104ee4285ec010f10609483cf41e4d365
with:
dfx-version: "0.27.0"

- name: 'Confirm dfx successful installation'
run: dfx --version

- name: 'Use free Solana RPC provider'
working-directory: examples/basic_solana/ninja
run: |
sed -i 's|solana_network = opt variant { Devnet }|solana_network = opt variant { Custom = record { url = \\"https://api.devnet.solana.com\\"; headers = null } }|g' dfx.json

- name: "Deploy locally"
working-directory: examples/basic_solana/ninja
run: |
dfx start --clean --background
dfx deploy
out=$(dfx canister call basic_solana solana_account --output json)
echo "$out"
echo "$out" | grep -E "[1-9A-HJ-NP-Za-km-z]{32,44}" > /dev/null || { echo "❌ Call to 'solana_account' failed"; exit 1; }
out=$(dfx canister call basic_solana get_balance --output json)
echo "$out"
echo "$out" | grep -E "[0-9]+(?:_[0-9]+)*" > /dev/null || { echo "❌ Call to 'get_balance' failed"; exit 1; }

@gregorydemay gregorydemay Sep 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there might be a problem with the grep since the job issues a warning

grep: warning: ? at start of expression

@lpahlavi lpahlavi Sep 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch! Turns out this is PCRE regex syntax for a non-capturing group, but we need POSIX syntax which doesn't support that. I've removed it (both in the icp-ninja-tests and ent-to-end-tests steps) as it's unnecessary for us.


integration-tests:
needs: [ reproducible-build ]
runs-on: ubuntu-22.04
Expand Down