chore: revert to symlink for basic_solana Ninja deployment#222
Merged
chore: revert to symlink for basic_solana Ninja deployment#222
basic_solana Ninja deployment#222Conversation
lpahlavi
force-pushed
the
lpahlavi/add-back-ninja-symlink
branch
from
1ab8daf to
452cd90
Compare
gregorydemay
approved these changes
Sep 2, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for the clean-up @lpahlavi ! Once merged, could you check that everything works as expected in ICP Ninja?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(XC-456) Due to the breaking changes in #197, the symlink for the
basic_solanaICP Ninja deployment source code was removed. Sincesol_rpc_clientandsol_rpc_typesv3.0.0 were released without the patchedsolana-*dependencies, this PR adds back the symlink and removes the duplicated code for thebasic_solanaICP Ninja deployment.