feat: add debug and trace logging to the webserver proxy#466
Merged
Conversation
blynn
reviewed
Mar 18, 2020
| .send_stream(payload) | ||
| let logger = data.logger.clone(); | ||
|
|
||
| // TODO(hansl): move this all to async/await. Jeez.... |
There was a problem hiding this comment.
Thanks to Google, I prefer filing an issue to TODOs. I don't know how it was on your team, but on ours, they would stay in there until the entire code became obsolete and got deleted. Recording it on buganizer meant you either got extra credit for doing the thing, or the issue magically and quietly disappeared on the next declaration of bug bankruptcy. Win-win!
Contributor
Author
There was a problem hiding this comment.
I have a tab in my IDE that shows TODOs. And we had talks and work into making a TODO bot that just adds GitHub issues based on TODOs.
Both systems have pros and cons. I've seen many P2-4 just get ignored and closed after 2 months due to inactivity. And a refactor TODO like this one would definitely not be P0-1 ;)
When G+ launched we even had "G0-4" priorities which were basically grouping priorities for projects (so a G0/P4 could potentially be more important than a G1/P0 which was weird). In the end the concept was trashed because everyone thought their jobs were G0... :/
Contributor
Author
There was a problem hiding this comment.
blynn
approved these changes
Mar 18, 2020
dfinity-bot
added a commit
that referenced
this pull request
Nov 2, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a0e59ff2...65b9aa70](rustsec/advisory-db@a0e59ff...65b9aa7) * [`0da539a2`](rustsec/advisory-db@0da539a) Add unmaintained crate advisory for `safe-nd` ([RustSec/advisory-db#467](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/467)) * [`51fd5e3c`](rustsec/advisory-db@51fd5e3) Assigned RUSTSEC-2020-0063 to safe-nd ([RustSec/advisory-db#469](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/469)) * [`3adba0fc`](rustsec/advisory-db@3adba0f) Add unmaintained crate advisory for `ffi_utils` ([RustSec/advisory-db#464](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/464)) * [`74c2e86f`](rustsec/advisory-db@74c2e86) Assigned RUSTSEC-2020-0064 to ffi_utils ([RustSec/advisory-db#470](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/470)) * [`a949bd46`](rustsec/advisory-db@a949bd4) Add unmaintained crate advisory for `fake_clock` ([RustSec/advisory-db#465](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/465)) * [`00a4c19a`](rustsec/advisory-db@00a4c19) Assigned RUSTSEC-2020-0065 to fake_clock ([RustSec/advisory-db#471](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/471)) * [`3761ab58`](rustsec/advisory-db@3761ab5) Add unmaintained crate advisory for `safe_bindgen` ([RustSec/advisory-db#466](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/466)) * [`d5cf9d76`](rustsec/advisory-db@d5cf9d7) Assigned RUSTSEC-2020-0066 to safe_bindgen ([RustSec/advisory-db#472](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/472)) * [`9757ff20`](rustsec/advisory-db@9757ff2) Add unmaintained crate advisory for `quic-p2p` ([RustSec/advisory-db#468](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/468)) * [`65b9aa70`](rustsec/advisory-db@65b9aa7) Assigned RUSTSEC-2020-0067 to quic-p2p ([RustSec/advisory-db#473](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/473))
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a0e59ff2...65b9aa70](rustsec/advisory-db@a0e59ff...65b9aa7) * [`0da539a2`](rustsec/advisory-db@0da539a) Add unmaintained crate advisory for `safe-nd` ([RustSec/advisory-db#467](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/467)) * [`51fd5e3c`](rustsec/advisory-db@51fd5e3) Assigned RUSTSEC-2020-0063 to safe-nd ([RustSec/advisory-db#469](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/469)) * [`3adba0fc`](rustsec/advisory-db@3adba0f) Add unmaintained crate advisory for `ffi_utils` ([RustSec/advisory-db#464](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/464)) * [`74c2e86f`](rustsec/advisory-db@74c2e86) Assigned RUSTSEC-2020-0064 to ffi_utils ([RustSec/advisory-db#470](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/470)) * [`a949bd46`](rustsec/advisory-db@a949bd4) Add unmaintained crate advisory for `fake_clock` ([RustSec/advisory-db#465](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/465)) * [`00a4c19a`](rustsec/advisory-db@00a4c19) Assigned RUSTSEC-2020-0065 to fake_clock ([RustSec/advisory-db#471](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/471)) * [`3761ab58`](rustsec/advisory-db@3761ab5) Add unmaintained crate advisory for `safe_bindgen` ([RustSec/advisory-db#466](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/466)) * [`d5cf9d76`](rustsec/advisory-db@d5cf9d7) Assigned RUSTSEC-2020-0066 to safe_bindgen ([RustSec/advisory-db#472](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/472)) * [`9757ff20`](rustsec/advisory-db@9757ff2) Add unmaintained crate advisory for `quic-p2p` ([RustSec/advisory-db#468](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/468)) * [`65b9aa70`](rustsec/advisory-db@65b9aa7) Assigned RUSTSEC-2020-0067 to quic-p2p ([RustSec/advisory-db#473](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/473))
dfinity-bot
added a commit
that referenced
this pull request
Oct 15, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e1850ce9...7750d6b2](https://github.com/dfinity-lab/common/compare/e1850ce9676d18460429d3c076e57834d1678eef...7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86) * [`7750d6b2`](https://github.com/dfinity-lab/common/commit/7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86) Add my new SSH key ([dfinity-lab/common#466](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/466))
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e1850ce9...7750d6b2](https://github.com/dfinity-lab/common/compare/e1850ce9676d18460429d3c076e57834d1678eef...7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86) * [`7750d6b2`](https://github.com/dfinity-lab/common/commit/7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86) Add my new SSH key ([dfinity-lab/common#466](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/466))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge base is #465 so that PR should be reviewed first.