Conversation
hansl
approved these changes
Mar 26, 2020
dfinity-bot
added a commit
that referenced
this pull request
Nov 2, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a0e59ff2...65b9aa70](rustsec/advisory-db@a0e59ff...65b9aa7) * [`0da539a2`](rustsec/advisory-db@0da539a) Add unmaintained crate advisory for `safe-nd` ([RustSec/advisory-db#467](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/467)) * [`51fd5e3c`](rustsec/advisory-db@51fd5e3) Assigned RUSTSEC-2020-0063 to safe-nd ([RustSec/advisory-db#469](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/469)) * [`3adba0fc`](rustsec/advisory-db@3adba0f) Add unmaintained crate advisory for `ffi_utils` ([RustSec/advisory-db#464](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/464)) * [`74c2e86f`](rustsec/advisory-db@74c2e86) Assigned RUSTSEC-2020-0064 to ffi_utils ([RustSec/advisory-db#470](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/470)) * [`a949bd46`](rustsec/advisory-db@a949bd4) Add unmaintained crate advisory for `fake_clock` ([RustSec/advisory-db#465](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/465)) * [`00a4c19a`](rustsec/advisory-db@00a4c19) Assigned RUSTSEC-2020-0065 to fake_clock ([RustSec/advisory-db#471](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/471)) * [`3761ab58`](rustsec/advisory-db@3761ab5) Add unmaintained crate advisory for `safe_bindgen` ([RustSec/advisory-db#466](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/466)) * [`d5cf9d76`](rustsec/advisory-db@d5cf9d7) Assigned RUSTSEC-2020-0066 to safe_bindgen ([RustSec/advisory-db#472](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/472)) * [`9757ff20`](rustsec/advisory-db@9757ff2) Add unmaintained crate advisory for `quic-p2p` ([RustSec/advisory-db#468](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/468)) * [`65b9aa70`](rustsec/advisory-db@65b9aa7) Assigned RUSTSEC-2020-0067 to quic-p2p ([RustSec/advisory-db#473](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/473))
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a0e59ff2...65b9aa70](rustsec/advisory-db@a0e59ff...65b9aa7) * [`0da539a2`](rustsec/advisory-db@0da539a) Add unmaintained crate advisory for `safe-nd` ([RustSec/advisory-db#467](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/467)) * [`51fd5e3c`](rustsec/advisory-db@51fd5e3) Assigned RUSTSEC-2020-0063 to safe-nd ([RustSec/advisory-db#469](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/469)) * [`3adba0fc`](rustsec/advisory-db@3adba0f) Add unmaintained crate advisory for `ffi_utils` ([RustSec/advisory-db#464](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/464)) * [`74c2e86f`](rustsec/advisory-db@74c2e86) Assigned RUSTSEC-2020-0064 to ffi_utils ([RustSec/advisory-db#470](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/470)) * [`a949bd46`](rustsec/advisory-db@a949bd4) Add unmaintained crate advisory for `fake_clock` ([RustSec/advisory-db#465](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/465)) * [`00a4c19a`](rustsec/advisory-db@00a4c19) Assigned RUSTSEC-2020-0065 to fake_clock ([RustSec/advisory-db#471](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/471)) * [`3761ab58`](rustsec/advisory-db@3761ab5) Add unmaintained crate advisory for `safe_bindgen` ([RustSec/advisory-db#466](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/466)) * [`d5cf9d76`](rustsec/advisory-db@d5cf9d7) Assigned RUSTSEC-2020-0066 to safe_bindgen ([RustSec/advisory-db#472](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/472)) * [`9757ff20`](rustsec/advisory-db@9757ff2) Add unmaintained crate advisory for `quic-p2p` ([RustSec/advisory-db#468](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/468)) * [`65b9aa70`](rustsec/advisory-db@65b9aa7) Assigned RUSTSEC-2020-0067 to quic-p2p ([RustSec/advisory-db#473](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/473))
dfinity-bot
added a commit
that referenced
this pull request
Sep 17, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e38b69b1...85c4d3f3](https://github.com/dfinity-lab/common/compare/e38b69b1fdd31a9012a994f934c0aebc4b9099e0...85c4d3f3185d630e28ddffece714e06d032b9b67) * [`85c4d3f3`](https://github.com/dfinity-lab/common/commit/85c4d3f3185d630e28ddffece714e06d032b9b67) [PFOPS-477] Deactivate user account 'govinda' ([dfinity-lab/common#464](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/464))
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e38b69b1...85c4d3f3](https://github.com/dfinity-lab/common/compare/e38b69b1fdd31a9012a994f934c0aebc4b9099e0...85c4d3f3185d630e28ddffece714e06d032b9b67) * [`85c4d3f3`](https://github.com/dfinity-lab/common/commit/85c4d3f3185d630e28ddffece714e06d032b9b67) [PFOPS-477] Deactivate user account 'govinda' ([dfinity-lab/common#464](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/464))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR looks large, but it simply cuts
idl-ui.tsinto two smaller pieces for extensibility:candid-core.tscontains theInputBoxandInputFormclass definitions. Most of theHTMLElementare factored out, and becomes input to the class.candid-ui.tsis the implementation of theRenderandParseclass that specify the actualHTMLElementused for the UI.cssfile out ofindex.html.The goal is that developers only need to implement
candid-ui.tsfor customizing their UIs, and the core.ts always stays the same.Guide for reviewers: The diff is mostly due to change in
package-lock.json. Almost all the code in core and ui stays the same as before. The only thing I add is the interface type for specifying HTMLElement, which are at the top of the ts files.