Skip to content

Comments

fix: Fix issues with Node in the Userlib#435

Merged
hansl merged 4 commits intomasterfrom
hansl/userlib-node-fix
Mar 8, 2020
Merged

fix: Fix issues with Node in the Userlib#435
hansl merged 4 commits intomasterfrom
hansl/userlib-node-fix

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Mar 7, 2020

Includes an __install call on actors to install a module with a canisterId. This allows for parity with other Userlibs.

@hansl hansl requested a review from a team as a code owner March 7, 2020 04:05
@hansl hansl mentioned this pull request Mar 7, 2020
Merged
chenyan-dfinity
chenyan-dfinity approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.

@hansl
Copy link
Contributor Author

hansl commented Mar 8, 2020

All comments are addressed. Waiting for CI to merge.

@hansl hansl merged commit f905f17 into master Mar 8, 2020
@hansl hansl deleted the hansl/userlib-node-fix branch March 8, 2020 19:59
dfinity-bot added a commit that referenced this pull request Oct 26, 2020
@dfinity-bot
build: niv advisory-db: update 6e48979d -> 0ad26bc7
9af7c84 
## Changelog for advisory-db:
Branch: master
Commits: [rustsec/advisory-db@6e48979d...0ad26bc7](rustsec/advisory-db@6e48979...0ad26bc)

* [`5751a5f4`](rustsec/advisory-db@5751a5f) CI: bump rustsec-admin to v0.3.0-pre2 ([RustSec/advisory-db⁠#438](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/438))
* [`65441901`](rustsec/advisory-db@6544190) Add unmaintained crate advisory for stdweb ([RustSec/advisory-db⁠#439](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/439))
* [`acc73d95`](rustsec/advisory-db@acc73d9) CI: bump rustsec-admin to v0.3.0-pre3 ([RustSec/advisory-db⁠#440](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/440))
* [`691a7504`](rustsec/advisory-db@691a750) Assigned RUSTSEC-2020-0056 to stdweb ([RustSec/advisory-db⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/441))
* [`8505c957`](rustsec/advisory-db@8505c95) Add unmaintained crate advisory for `block-cipher` ([RustSec/advisory-db⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/442))
* [`fa616899`](rustsec/advisory-db@fa61689) Assigned RUSTSEC-2020-0057 to block-cipher ([RustSec/advisory-db⁠#443](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/443))
* [`5c9ebbfa`](rustsec/advisory-db@5c9ebbf) Add unmaintained crate advisory for `stream-cipher` ([RustSec/advisory-db⁠#444](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/444))
* [`218de91a`](rustsec/advisory-db@218de91) Assigned RUSTSEC-2020-0058 to stream-cipher ([RustSec/advisory-db⁠#445](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/445))
* [`681a2040`](rustsec/advisory-db@681a204) Add advisory for notable UB fix in libpulse-binding v2.6.0 ([RustSec/advisory-db⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/435))
* [`1e48ac39`](rustsec/advisory-db@1e48ac3) Assigned RUSTSEC-2019-0038 to libpulse-binding ([RustSec/advisory-db⁠#446](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/446))
* [`59bee556`](rustsec/advisory-db@59bee55) Add advisory for use-after-frees fixed in libpulse-binding v1.2.1 ([RustSec/advisory-db⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/433))
* [`146de2d8`](rustsec/advisory-db@146de2d) Assigned RUSTSEC-2018-0021 to libpulse-binding ([RustSec/advisory-db⁠#447](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/447))
* [`3b1f08f2`](rustsec/advisory-db@3b1f08f) Unyank RUSTSEC-2020-0011 ([RustSec/advisory-db⁠#448](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/448))
* [`3796cc00`](rustsec/advisory-db@3796cc0) README.md: point chat badge to Zulip ([RustSec/advisory-db⁠#449](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/449))
* [`1bf68e0d`](rustsec/advisory-db@1bf68e0) RUSTSEC-2020-0015: use wildcards in version req ([RustSec/advisory-db⁠#450](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/450))
* [`67a2144b`](rustsec/advisory-db@67a2144) RUSTSEC-2020-0015: remove wildcards ([RustSec/advisory-db⁠#451](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/451))
* [`0ad26bc7`](rustsec/advisory-db@0ad26bc) Bump `rustsec-admin` to v0.3.0 ([RustSec/advisory-db⁠#452](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/452))
mergify bot pushed a commit that referenced this pull request Oct 26, 2020
@dfinity-bot
build: niv advisory-db: update 6e48979d -> 0ad26bc7 (#1143)
71404ee 
## Changelog for advisory-db:
Branch: master
Commits: [rustsec/advisory-db@6e48979d...0ad26bc7](rustsec/advisory-db@6e48979...0ad26bc)

* [`5751a5f4`](rustsec/advisory-db@5751a5f) CI: bump rustsec-admin to v0.3.0-pre2 ([RustSec/advisory-db⁠#438](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/438))
* [`65441901`](rustsec/advisory-db@6544190) Add unmaintained crate advisory for stdweb ([RustSec/advisory-db⁠#439](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/439))
* [`acc73d95`](rustsec/advisory-db@acc73d9) CI: bump rustsec-admin to v0.3.0-pre3 ([RustSec/advisory-db⁠#440](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/440))
* [`691a7504`](rustsec/advisory-db@691a750) Assigned RUSTSEC-2020-0056 to stdweb ([RustSec/advisory-db⁠#441](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/441))
* [`8505c957`](rustsec/advisory-db@8505c95) Add unmaintained crate advisory for `block-cipher` ([RustSec/advisory-db⁠#442](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/442))
* [`fa616899`](rustsec/advisory-db@fa61689) Assigned RUSTSEC-2020-0057 to block-cipher ([RustSec/advisory-db⁠#443](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/443))
* [`5c9ebbfa`](rustsec/advisory-db@5c9ebbf) Add unmaintained crate advisory for `stream-cipher` ([RustSec/advisory-db⁠#444](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/444))
* [`218de91a`](rustsec/advisory-db@218de91) Assigned RUSTSEC-2020-0058 to stream-cipher ([RustSec/advisory-db⁠#445](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/445))
* [`681a2040`](rustsec/advisory-db@681a204) Add advisory for notable UB fix in libpulse-binding v2.6.0 ([RustSec/advisory-db⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/435))
* [`1e48ac39`](rustsec/advisory-db@1e48ac3) Assigned RUSTSEC-2019-0038 to libpulse-binding ([RustSec/advisory-db⁠#446](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/446))
* [`59bee556`](rustsec/advisory-db@59bee55) Add advisory for use-after-frees fixed in libpulse-binding v1.2.1 ([RustSec/advisory-db⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/433))
* [`146de2d8`](rustsec/advisory-db@146de2d) Assigned RUSTSEC-2018-0021 to libpulse-binding ([RustSec/advisory-db⁠#447](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/447))
* [`3b1f08f2`](rustsec/advisory-db@3b1f08f) Unyank RUSTSEC-2020-0011 ([RustSec/advisory-db⁠#448](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/448))
* [`3796cc00`](rustsec/advisory-db@3796cc0) README.md: point chat badge to Zulip ([RustSec/advisory-db⁠#449](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/449))
* [`1bf68e0d`](rustsec/advisory-db@1bf68e0) RUSTSEC-2020-0015: use wildcards in version req ([RustSec/advisory-db⁠#450](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/450))
* [`67a2144b`](rustsec/advisory-db@67a2144) RUSTSEC-2020-0015: remove wildcards ([RustSec/advisory-db⁠#451](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/451))
* [`0ad26bc7`](rustsec/advisory-db@0ad26bc) Bump `rustsec-admin` to v0.3.0 ([RustSec/advisory-db⁠#452](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/452))
dfinity-bot added a commit that referenced this pull request Jun 10, 2021
@dfinity-bot
build: niv common: update 02d06647 -> 28d0cdbc
277b19c 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@02d06647...28d0cdbc](https://github.com/dfinity-lab/common/compare/02d0664796f51c9a0baff08c923217b4d50cad6a...28d0cdbc0eeb4f35e845bbec1d0a9f086b707493)

* [`32ab28ce`](https://github.com/dfinity-lab/common/commit/32ab28cecb8c979b8198aeab18ba0a1363651742) Add an SSH key for Ulan ([dfinity-lab/common⁠#430](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/430))
* [`0852e9f8`](https://github.com/dfinity-lab/common/commit/0852e9f82fbce60fe9bc50be6fbe1f65043750a9) Fix rust-src path ([dfinity-lab/common⁠#431](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/431))
* [`2bba7c6b`](https://github.com/dfinity-lab/common/commit/2bba7c6b6ddbba0069ced1527d0ee6478d484e79) Fix niv-updater-action ([dfinity-lab/common⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/433))
* [`28d0cdbc`](https://github.com/dfinity-lab/common/commit/28d0cdbc0eeb4f35e845bbec1d0a9f086b707493) niv naersk: update e8061169 -> 4f7426c3 ([dfinity-lab/common⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/435))
mergify bot pushed a commit that referenced this pull request Jun 10, 2021
@dfinity-bot
build: niv common: update 02d06647 -> 28d0cdbc (#1706)
596611d 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@02d06647...28d0cdbc](https://github.com/dfinity-lab/common/compare/02d0664796f51c9a0baff08c923217b4d50cad6a...28d0cdbc0eeb4f35e845bbec1d0a9f086b707493)

* [`32ab28ce`](https://github.com/dfinity-lab/common/commit/32ab28cecb8c979b8198aeab18ba0a1363651742) Add an SSH key for Ulan ([dfinity-lab/common⁠#430](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/430))
* [`0852e9f8`](https://github.com/dfinity-lab/common/commit/0852e9f82fbce60fe9bc50be6fbe1f65043750a9) Fix rust-src path ([dfinity-lab/common⁠#431](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/431))
* [`2bba7c6b`](https://github.com/dfinity-lab/common/commit/2bba7c6b6ddbba0069ced1527d0ee6478d484e79) Fix niv-updater-action ([dfinity-lab/common⁠#433](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/433))
* [`28d0cdbc`](https://github.com/dfinity-lab/common/commit/28d0cdbc0eeb4f35e845bbec1d0a9f086b707493) niv naersk: update e8061169 -> 4f7426c3 ([dfinity-lab/common⁠#435](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/435))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hansl @chenyan-dfinity