Skip to content

Comments

feat: SDK-713 npm package structure for userlib#370

Merged
hansl merged 4 commits intomasterfrom
hansl/npm-package
Feb 17, 2020
Merged

feat: SDK-713 npm package structure for userlib#370
hansl merged 4 commits intomasterfrom
hansl/npm-package

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Feb 10, 2020 •
edited
Loading

This looks like this:

image

@hansl hansl force-pushed the hansl/npm-package branch 2 times, most recently from 99997f7 to 4ffb3ba Compare February 10, 2020 23:44
@hansl hansl changed the title feat: npm package structure for userlib feat: SDK-713 npm package structure for userlib Feb 10, 2020
@hansl hansl force-pushed the hansl/npm-package branch from 4ffb3ba to fc18386 Compare February 12, 2020 01:17
@hansl hansl force-pushed the hansl/npm-package branch from fc18386 to c75570c Compare February 14, 2020 20:40
@hansl hansl marked this pull request as ready for review February 14, 2020 21:13
@hansl hansl requested a review from a team February 14, 2020 21:13
@hansl hansl requested a review from a team as a code owner February 14, 2020 21:13
eftychis
eftychis reviewed Feb 14, 2020
View reviewed changes
chenyan-dfinity
chenyan-dfinity reviewed Feb 14, 2020
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Does this mean userlib is now semi-open-source? Do we need explicit approval for this?
  2. Can you write a README for internal engineers on how to develop userlib? We used to do npm run bundle and copy dist to cache. I think now it's going to change to something else.

@eftychis
Copy link
Contributor

eftychis commented Feb 14, 2020

Yes I think some readme is necessary here. Also some notes on next steps.

@eftychis
Copy link
Contributor

eftychis commented Feb 14, 2020

Otherwise, this looks fine to me minus minor notes above.

@hansl
Copy link
Contributor Author

hansl commented Feb 14, 2020

Does this mean userlib is now semi-open-source? Do we need explicit approval for this?

This enables this, but does not release it yet.

Can you write a README for internal engineers on how to develop userlib? We used to do npm run bundle and copy dist to cache. I think now it's going to change to something else.

Sure!

eftychis
eftychis approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@eftychis eftychis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add the README for development then this LGTM.

Thanks Hans 😎

@hansl
Copy link
Contributor Author

hansl commented Feb 17, 2020

@eftychis @chenyan-dfinity PTAL.

chenyan-dfinity
chenyan-dfinity approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@hansl hansl merged commit 7fc2cdf into master Feb 17, 2020
@hansl hansl deleted the hansl/npm-package branch February 17, 2020 18:50
hansl pushed a commit that referenced this pull request Feb 17, 2020
Revert "feat: SDK-713 npm package structure for userlib (#370)"
f29a3fc 
This reverts commit 7fc2cdf.
hansl pushed a commit that referenced this pull request Feb 17, 2020
Revert "feat: SDK-713 npm package structure for userlib (#370)" (#378)
71e6dc9 
This reverts commit 7fc2cdf.
hansl pushed a commit that referenced this pull request Feb 19, 2020
feat: SDK-713 npm package structure for userlib (#370)
fe2615d
hansl pushed a commit that referenced this pull request Feb 28, 2020
feat: SDK-713 npm package structure for userlib (#370)
944c5e4
hansl pushed a commit that referenced this pull request Feb 28, 2020
feat: SDK-713 npm package structure for userlib (#370) (#392)
4cc4643
dfinity-bot added a commit that referenced this pull request Aug 28, 2020
@dfinity-bot
build: niv advisory-db: update 47d12507 -> c341943a
1b2b959 
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))
mergify bot pushed a commit that referenced this pull request Aug 28, 2020
@dfinity-bot
build: niv advisory-db: update 47d12507 -> c341943a (#970)
e644f5e 
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))
gobengo pushed a commit that referenced this pull request Sep 1, 2020
@dfinity-bot @gobengo
build: niv advisory-db: update 47d12507 -> c341943a (#970)
9bc2689 
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))
dfinity-bot added a commit that referenced this pull request Mar 11, 2021
@dfinity-bot
build: niv common: update 22ad8d18 -> 79cb92b1
7112a89 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@22ad8d18...79cb92b1](https://github.com/dfinity-lab/common/compare/22ad8d18f6b20cedf6b4501754c151c7c7bc1bae...79cb92b15060e1fb50c3d24ace426a590d15103b)

* [`dd60a250`](https://github.com/dfinity-lab/common/commit/dd60a250dbc5b6b9555e70441c679d48f4dc7e74) added Jeff Anderson SSH Key ([dfinity-lab/common⁠#380](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/380))
* [`79cb92b1`](https://github.com/dfinity-lab/common/commit/79cb92b15060e1fb50c3d24ace426a590d15103b) Add a line for updating the backport branch ([dfinity-lab/common⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/370))
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
@dfinity-bot
build: niv common: update 22ad8d18 -> 79cb92b1 (#1492)
de003e4 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@22ad8d18...79cb92b1](https://github.com/dfinity-lab/common/compare/22ad8d18f6b20cedf6b4501754c151c7c7bc1bae...79cb92b15060e1fb50c3d24ace426a590d15103b)

* [`dd60a250`](https://github.com/dfinity-lab/common/commit/dd60a250dbc5b6b9555e70441c679d48f4dc7e74) added Jeff Anderson SSH Key ([dfinity-lab/common⁠#380](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/380))
* [`79cb92b1`](https://github.com/dfinity-lab/common/commit/79cb92b15060e1fb50c3d24ace426a590d15103b) Add a line for updating the backport branch ([dfinity-lab/common⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/370))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk basvandijk approved these changes

+2 more reviewers

@eftychis eftychis eftychis approved these changes

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hansl @eftychis @basvandijk @chenyan-dfinity