Revert "feat: SDK-713 npm package structure for userlib (#370)"#378

Merged

hansl merged 1 commit intomasterfrom

hansl/revert-370

Feb 17, 2020

Contributor

hansl commented Feb 17, 2020

This reverts commit 7fc2cdf.

This breaks new apps.


          Revert "feat: SDK-713 npm package structure for userlib (#370)"

f29a3fc

This reverts commit 7fc2cdf.

hansl requested a review from a team

February 17, 2020 21:10

hansl requested a review from a team as a code owner

February 17, 2020 21:10

Contributor

chenyan-dfinity commented Feb 17, 2020

What breaks? Seems fine on my branch.

Contributor Author

hansl commented Feb 17, 2020

New apps cannot build because there are missing dependencies.

chenyan-dfinity approved these changes

View reviewed changes

hansl merged commit 71e6dc9 into master

nmattia deleted the hansl/revert-370 branch

February 18, 2020 09:44

dfinity-bot added a commit that referenced this pull request


          build: niv common: update 43c86c9f -> 22ad8d18

8dd7b98

## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@43c86c9f...22ad8d18](https://github.com/dfinity-lab/common/compare/43c86c9f80a82577da4c35bf7c1ece491d71016d...22ad8d18f6b20cedf6b4501754c151c7c7bc1bae)

* [`6242df59`](https://github.com/dfinity-lab/common/commit/6242df59f04fa680cc3627d5653bc6d20a03444d) [VER-612] Do not patch libunwind, as it makes _Unwind_RaiseException unsafe to call ([dfinity-lab/common⁠#376](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/376))
* [`9a6ce05f`](https://github.com/dfinity-lab/common/commit/9a6ce05fb33bacb8f9c278e6b4dbea26137d1f4f) Take LLVM 9 out of tree ([dfinity-lab/common⁠#378](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/378))
* [`22ad8d18`](https://github.com/dfinity-lab/common/commit/22ad8d18f6b20cedf6b4501754c151c7c7bc1bae) Revert "darwin: Only build required jobs ([dfinity-lab/common⁠#374](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/374))" ([dfinity-lab/common⁠#379](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/379))

mergify bot pushed a commit that referenced this pull request


          build: niv common: update 43c86c9f -> 22ad8d18 (#1490)

97df09d

## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@43c86c9f...22ad8d18](https://github.com/dfinity-lab/common/compare/43c86c9f80a82577da4c35bf7c1ece491d71016d...22ad8d18f6b20cedf6b4501754c151c7c7bc1bae)

* [`6242df59`](https://github.com/dfinity-lab/common/commit/6242df59f04fa680cc3627d5653bc6d20a03444d) [VER-612] Do not patch libunwind, as it makes _Unwind_RaiseException unsafe to call ([dfinity-lab/common⁠#376](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/376))
* [`9a6ce05f`](https://github.com/dfinity-lab/common/commit/9a6ce05fb33bacb8f9c278e6b4dbea26137d1f4f) Take LLVM 9 out of tree ([dfinity-lab/common⁠#378](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/378))
* [`22ad8d18`](https://github.com/dfinity-lab/common/commit/22ad8d18f6b20cedf6b4501754c151c7c7bc1bae) Revert "darwin: Only build required jobs ([dfinity-lab/common⁠#374](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/374))" ([dfinity-lab/common⁠#379](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/379))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet