fix: bug in slebEncode#368

Merged

hansl merged 3 commits intomasterfrom

Feb 11, 2020

Contributor

chenyan-dfinity commented Feb 9, 2020

lebEncode and slebEncode for positive numbers are not the same. Refactor both functions to make the difference clear.

chenyan-dfinity added 3 commits

February 9, 2020 12:58


          fix: bug in slebEncode

4cb8bf2

fix

f8d4907

fix

3922cc0

chenyan-dfinity marked this pull request as ready for review

February 9, 2020 21:11

chenyan-dfinity requested a review from a team as a code owner

February 9, 2020 21:11

chenyan-dfinity mentioned this pull request

feat: add candid UI for canister #356

Merged

hansl approved these changes

View reviewed changes

hansl merged commit d4ef458 into master

dfinity-bot added a commit that referenced this pull request


          build: niv advisory-db: update 47d12507 -> c341943a

1b2b959

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))

mergify bot pushed a commit that referenced this pull request


          build: niv advisory-db: update 47d12507 -> c341943a (#970)

e644f5e

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))

gobengo pushed a commit that referenced this pull request


          build: niv advisory-db: update 47d12507 -> c341943a (#970)

9bc2689

## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@47d12507...c341943a](rustsec/advisory-db@47d1250...c341943)

* [`91aeb3b0`](rustsec/advisory-db@91aeb3b) Suggest lz-fear as an alternative to lz4-compress
* [`002af101`](rustsec/advisory-db@002af10) failure: add informational "unmaintained" advisory ([RustSec/advisory-db⁠#368](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/368))
* [`1d3ca115`](rustsec/advisory-db@1d3ca11) Assigned RUSTSEC-2020-0036 to failure ([RustSec/advisory-db⁠#369](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/369))
* [`df8a0c46`](rustsec/advisory-db@df8a0c4) RUSTSEC-2020-0036: add fehler ([RustSec/advisory-db⁠#370](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/370))

lwshang deleted the leb-fix branch

July 29, 2022 18:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet