Conversation
|
|
||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| Ok(CanisterId::from_u64(u64::from_str(s)?)) | ||
| Ok(CanisterId(Blob(s.to_string().into_bytes()))) |
There was a problem hiding this comment.
Maybe not in this PR, but what is the semantics of from_str? A str is text, never binary data (“String slices are always valid UTF-8.” according to the docs), so I guess this trait should either decode the the textual representation, or maybe simply not exist.
There was a problem hiding this comment.
That is a good point and I was planning to fix it actually here, after other fires in this PR get resolved. I will continue working on this today most likely. If it ends up being to much work I will file it as a high priority bug (due to how hard it will be to debug) and defer for follow up.
|
Could I need this to get |
|
hat trick ;) |
3 participants
No description provided.