Skip to content

Comments

bump motoko#337

Merged
chenyan-dfinity merged 8 commits intomasterfrom
bump-motoko
Jan 29, 2020
Merged

bump motoko#337
chenyan-dfinity merged 8 commits intomasterfrom
bump-motoko

Conversation

@chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jan 24, 2020

No description provided.

@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review January 28, 2020 22:39
@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner January 28, 2020 22:39
@@ -1,15 +0,0 @@
#!/usr/bin/env bats
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant test. print.mo is exactly the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any good tests to add instead?

format!("Cannot find import file {}", path.display()),
)));
}
let import = parse_moc_deps(dep)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenyan-dfinity chenyan-dfinity merged commit 75ca454 into master Jan 29, 2020
@chenyan-dfinity chenyan-dfinity deleted the bump-motoko branch January 29, 2020 19:01
@eftychis eftychis mentioned this pull request Jan 30, 2020
dfinity-bot added a commit that referenced this pull request Jul 24, 2020
mergify bot pushed a commit that referenced this pull request Jul 24, 2020
andrewwylde pushed a commit that referenced this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants